Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dapr --app-port argument not consistently passed to the dapr executable #2367

Closed
darraghjones opened this issue Feb 23, 2024 · 3 comments
Closed
Labels

Comments

@darraghjones
Copy link

I see the following error in the dapr logs because the app-port argument is not passed to the dapr executable.

time="2024-02-23T00:06:55.4110487Z" level=warning msg="App channel is not initialized. Did you configure an app-port?" app_id=web instance=DESKTOP-SE6C36R scope=dapr.runtime.channels type=log ver=1.12.5

You can see this happening below running the AspireWithDapr sample

image

The app-port argument is being passed to the API service dapr instance, but I couldn't see any reason why it would behave differently.

@darraghjones
Copy link
Author

darraghjones commented Feb 23, 2024

Ah, it seems this has to do with the frontend running on https. If i change this to http, the app-port argument is passed along to dapr.

@davidfowl
Copy link
Member

Not sure what we can do about this

karolz-ms pushed a commit that referenced this issue Apr 11, 2024
* dapr change the app port depending on the app protocol

* fix endpoint annotations for dapr.

* fix the rest of the endpoints uri schemas

* Apply suggestions from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>

* fix white spaces

* now we can define both, dapr protocol or endpoint from the configured endpoint

* add tests

* revert changes in the playground

* fix spelling issue

* add a large comment for all of this logic

* fix formatting

* Update src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs

* change to switch expression fix test

* revert changes in playground

* format stuff

* fix is null and formating

* improve switch

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
karolz-ms pushed a commit that referenced this issue Apr 11, 2024
* dapr change the app port depending on the app protocol

* fix endpoint annotations for dapr.

* fix the rest of the endpoints uri schemas

* Apply suggestions from code review

Co-authored-by: David Fowler <davidfowl@gmail.com>

* fix white spaces

* now we can define both, dapr protocol or endpoint from the configured endpoint

* add tests

* revert changes in the playground

* fix spelling issue

* add a large comment for all of this logic

* fix formatting

* Update src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs

* change to switch expression fix test

* revert changes in playground

* format stuff

* fix is null and formating

* improve switch

---------

Co-authored-by: David Fowler <davidfowl@gmail.com>
danmoseley pushed a commit that referenced this issue Apr 12, 2024
…3626)

* dapr change the app port depending on the app protocol

* fix endpoint annotations for dapr.

* fix the rest of the endpoints uri schemas

* Apply suggestions from code review



* fix white spaces

* now we can define both, dapr protocol or endpoint from the configured endpoint

* add tests

* revert changes in the playground

* fix spelling issue

* add a large comment for all of this logic

* fix formatting

* Update src/Aspire.Hosting.Dapr/DaprDistributedApplicationLifecycleHook.cs

* change to switch expression fix test

* revert changes in playground

* format stuff

* fix is null and formating

* improve switch

---------

Co-authored-by: paule96 <paul-jeschke@outlook.com>
Co-authored-by: David Fowler <davidfowl@gmail.com>
@davidfowl
Copy link
Member

Allowed specifying the endpoint to use for the sidecar resource. This determines the app port.

Fixed in #3184

@davidfowl davidfowl added this to the preview 6 (Apr) milestone Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

No branches or pull requests

3 participants