[release/8.0] Allow configuring claim requirements for frontend authorization #3619
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Adds optional configuration that checks a given claim of a user authenticated via OIDC. Two new configuration values are: - `Dashboard:Frontend:OpenIdConnect:RequireClaimType` specifies the (optional) claim that be present for authorized users. Defaults to empty. - `Dashboard:Frontend:OpenIdConnect:RequireClaimValue` specifies the (optional) value of the required claim. Only used if `Dashboard:Frontend:OpenIdConnect:RequireClaimType` is also specified. Defaults to empty.
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
|
discussed offline, approved. please work with Bala or otherwise to mitigate risk after it goes in. |
|
I'm going to do some manual testing on this branch before it's merged. |
kvenkatrajan
approved these changes
Apr 11, 2024
This was merged before my testing completed. I'm pushing a follow-up PR. |
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3595 to release/8.0
/cc @kvenkatrajan @drewnoakes
Customer Impact
Testing
Risk
Regression?
Microsoft Reviewers: Open in CodeFlow