[release/8.0] Introduce WithEnvironment(this, string, IResourceBuilder<IResourceWithConnectionString) #3549
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…3002 (#3239) * Update ResourceBuilderExtensions.cs Allow custom env var names for connection strings Introduce a new WithEnvironment overload in ResourceBuilderExtensions that enables setting a connection string under a custom environment variable name. Fixes #3002. * Update ResourceBuilderExtensions.cs * Update ResourceBuilderExtensions.cs * Update src/Aspire.Hosting/ResourceBuilderExtensions.cs * Remove async keyword * Added unit tests to verify the behavior of the WithEnvironment method * typo fix * verify the behavior of the WithEnvironment extension method in run mode * Apply suggestions from code review --------- Co-authored-by: David Fowler <davidfowl@gmail.com>
dotnet-issue-labeler
bot
added
the
area-app-model
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
danmoseley
approved these changes
Apr 10, 2024
davidfowl
approved these changes
Apr 10, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting changes from main:
Customer Impact
Improves the WithEnvironment API to allow people to inject a connection string where the receiving resource might not be using the standard .NET Core.
Testing
Unit tested. It has been in main for ~2 weeks and probably should have been in the branch in the first place.
Risk
Low. Unit tests added, doesn't interact with any default code path. But does make some other backports easier if we decide to take them.
Regression?
No