[release/8.0]: Backporting dashboard refactoring #3548
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Improve service address allocation Should fix #3265
* Make the dashboard an appmodel resource - Moved dashboard resource into a lifecycle hook instead of making it a dcp resource. This removes the specialized code from ApplicationExecutor from knowing about the dashboard. As a result of this change I also cleaned up how we configure and validate dcp options to use IConfigureOptions and IValidateOptions. - Added tests for the dashboard resource - Made a change to ApplicationExecutor to allow resources that start as hidden to remain hidden. - Added hidden to a new known resource states class - Added more test cases
* Only add dashboard services if the dashboard is enabled
#3472) - Print it right after we print the dashboard url - Refactored the dashboard resource to use DashboardOptions instead of DcpOptions
dotnet-issue-labeler
bot
added
the
area-codeflow
dotnet-policy-service
bot
added
the
Servicing-consider
danmoseley
added
Servicing-approved
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backporting changes from main:
Customer Impact
Backporting improvements to how the dashboard is modeled in the app model along with other reliability fixes. There are other fixes in this PR to do with test reliability.
Testing
This change itself adds LOTS of test coverage we didn't have before. That was one of the main purposes of the refactoring.
Risk
Medium. This is a big refactoring, but it has been running in main for a couple of days and we have runway to fix issues (we fixed a couple already).
We have 2 other PRs coming that depend build on this change. There's risk in doing it differently in main and release/8.0.
Regression?
No