Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Remove InternalsVisibleTo from Aspire.Hosting to Aspire.Hosting.Testing #3208

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 27, 2024

Backport of #3193 to release/8.0-preview5

/cc @davidfowl @ReubenBond

Customer Impact

This reduces the chance for issues caused by customers referencing mismatched versions of the Aspire.Hosting and Aspire.Hosting.Testing packages.

Testing

We have CI tests which cover the main scenarios of the testing package. These CI tests would be failing or flaky if the PR does not function as intended.

Risk

Low. If there is an issue with the functionality of the PR, the Aspire.Hosting.Testing package will not function as intended, resulting in a poor testing experience for developers.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 27, 2024
@davidfowl davidfowl requested a review from ReubenBond March 27, 2024 07:06
@davidfowl davidfowl merged commit 4d3325b into release/8.0-preview5 Mar 27, 2024
7 checks passed
@davidfowl davidfowl deleted the backport/pr-3193-to-release/8.0-preview5 branch March 27, 2024 15:30
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators Apr 27, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants