[release/8.0-preview5] Ensure logAnalyticsWorkspaceId parameter is present in Aspire manifest. #3302
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
dotnet-issue-labeler
bot
added
the
area-app-model
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3296 to release/8.0-preview5
/cc @mitchdenny
Customer Impact
The Application Insights resource is currently broken. We aren't correctly populating the logAnalyticsWorkspaceId parameter in the generated Bicep. We also want to give people the ability to create their own Log Analytics Workspace and associate with their AppInsights instance.
Testing
Unit tests added to verify that correct Bicep and manifest is created depending on the usage scenario as well as manual testing for deployments to Azure via Azure Provisioning and AZD.
Risk
Low. What we have is already busted, this fixes it.
Microsoft Reviewers: Open in CodeFlow