[release/8.0] [tests] Use ResiliencePipeline in IntegrationTests #3623
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
.. with a policy to retry with 1 sec delays, and a total timeout of 90 secs on the service side. The test(client) side has an overall http request timeout for 120 secs which would allow the real errors from the service to get surfaced to the client.
…han one resource is given
https://learn.microsoft.com/en-us/dotnet/fundamentals/code-analysis/quality-rules/ca1305 ``` dotnet_diagnostic.CA1305.severity = none ``` Addresses review feedback from @ eerhardt .
dotnet-issue-labeler
bot
added
the
area-integrations
dotnet-policy-service
bot
added
the
Servicing-consider
|
As I understand it, the polly change is purely moving to the newer polly API, so build validation is perhaps sufficient. The rest is test only changes. |
danmoseley
added
Servicing-approved
Yeah we used this opportunity to reduce our dependencies to just Polly.core and Polly.extensions. The full Polly is not needed. Removing the dependency later might be considered a breaking change. Since it builds and tests pass there shouldn’t be any risk. |
eerhardt
approved these changes
Apr 11, 2024
radical
approved these changes
Apr 12, 2024
Closed
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport of #3385 to release/8.0
/cc @radical
Customer Impact
Testing
Risk
Regression?
Microsoft Reviewers: Open in CodeFlow