Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0-preview5] Fix the dapr scheme to be http so that the sidecar works #3297

Merged

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Mar 30, 2024

Fixes #3290

Backport of #3292 to release/8.0-preview5

/cc @davidfowl

Customer Impact

We (I) broke the dapr extension because these endpoints aren't deemed HTTP endpoints anymore. This is a regression from preview4 (we didn't have any testing for dapr). Dapr is an important reason people use the aspire orchestration.

Testing

We have a new unit test and I ran the sample.

Risk

Low

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Mar 30, 2024
@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-integrations Issues pertaining to Aspire Integrations packages labels Mar 30, 2024
@davidfowl davidfowl linked an issue Mar 30, 2024 that may be closed by this pull request
@davidfowl davidfowl added this to the preview 5 (Apr) milestone Mar 30, 2024
@joperezr joperezr merged commit e0fe4a5 into release/8.0-preview5 Apr 1, 2024
7 checks passed
@joperezr joperezr deleted the backport/pr-3292-to-release/8.0-preview5 branch April 1, 2024 14:57
@DamianEdwards DamianEdwards mentioned this pull request Apr 1, 2024
@danmoseley danmoseley mentioned this pull request Apr 12, 2024
@github-actions github-actions bot locked and limited conversation to collaborators May 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dapr is broken
4 participants