Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WebToolsE2E] Using CLI, dotnet new Aspire Starter App and dotnet run, then wait for 30 seconds, we will see a warning saying it failed to get the dashboard logs #3612

Closed
balachir opened this issue Apr 11, 2024 · 2 comments · Fixed by #3636
Closed

[WebToolsE2E] Using CLI, dotnet new Aspire Starter App and dotnet run, then wait for 30 seconds, we will see a warning saying it failed to get the dashboard logs #3612

balachir opened this issue Apr 11, 2024 · 2 comments · Fixed by #3636
Assignees
@davidfowl
Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Milestone
preview 6 (Apr)

Comments

@balachir
Copy link

REGRESSION INFO: This is a new feature on Aspire 8.0.0-preview.6.24210.28

INSTALL STEPS
1.Clean machine: Win11 x64 23h2 ENU
2.Install SDK 8.0.204 (latest-released-build)
3.Install Aspire 8.0 P6 workload version 8.0.0-preview.6.24211.5, apply feeds

REPRO STEPS

  1. Open Command Prompt
  2. Create new app dotnet new aspire-starter -o AspireStarterApp03
  3. Go to folder cd AspireStarterApp03\AspireStarterApp03.AppHost
  4. Run the app dotnet run
  5. Wait for about 30 seconds

ACTUAL
We will see a warning saying it failed to get the dashboard logs
image

Before opening the URL of the dashboard in the browser, I was doing something else. When I came back to open the URL, I see this warning which is a bit confusing.

EXPECTED
The warning message should be more clear about what timed out and after how long
@davidfowl
Copy link
Member

Is it consistent?

@davidfowl
Copy link
Member

I can reproduce.

@davidfowl davidfowl self-assigned this Apr 12, 2024
@davidfowl davidfowl added area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication and removed area-dashboard labels Apr 12, 2024
@davidfowl davidfowl added this to the preview 6 (Apr) milestone Apr 12, 2024
davidfowl added a commit that referenced this issue Apr 12, 2024
@davidfowl
Fix dashboard log watching
9567956 
- When the dashboard was running as an executable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once.
- Deleted the timeout

Fixes #3612
@davidfowl davidfowl mentioned this issue Apr 12, 2024
Merged
github-actions bot pushed a commit that referenced this issue Apr 12, 2024
@davidfowl
Fix dashboard log watching - When the dashboard was running as an exe…
6ae2b50 
…cutable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once. - Deleted the timeout

Fixes #3612
davidfowl added a commit that referenced this issue Apr 12, 2024
@davidfowl
Fix dashboard log watching (#3636)
52cd9a8 
- When the dashboard was running as an executable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once.
- Deleted the timeout

Fixes #3612
@balachir balachir mentioned this issue Apr 12, 2024
Closed
github-actions bot pushed a commit that referenced this issue Apr 12, 2024
@davidfowl
Fix dashboard log watching - When the dashboard was running as an exe…
057e7d3 
…cutable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once. - Deleted the timeout

Fixes #3612
danmoseley pushed a commit that referenced this issue Apr 12, 2024
@github-actions @davidfowl
Fix dashboard log watching- Deleted the timeout (#3656)
e907f30 
Fixes #3612

Co-authored-by: David Fowler <davidfowl@gmail.com>
@github-actions github-actions bot locked and limited conversation to collaborators May 12, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@davidfowl davidfowl

Labels
area-app-model Issues pertaining to the APIs in Aspire.Hosting, e.g. DistributedApplication
Projects
None yet
Milestone
preview 6 (Apr)
Development

Successfully merging a pull request may close this issue.

Fix dashboard log watching dotnet/aspire
2 participants
@davidfowl @balachir