Fix dashboard log watching #3636
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- When the dashboard was running as an executable, the logic we used to detect replics in broken. Instead of trying to be clever, watch all dashboard resources and log their output. This is more robust and future proof as we only have one dashboard running at once. - Deleted the timeout Fixes #3612
|
Enabling auto merge, need to get this into p6. |
|
/backport to release/8.0 |
|
Started backporting to release/8.0: https://github.com/dotnet/aspire/actions/runs/8656577749 |
JamesNK
approved these changes
Apr 12, 2024
| // Wait for dashboard to startup and be reported before giving up. | ||
| using var cts = new CancellationTokenSource(timeout); | ||
| using var linkedCts = CancellationTokenSource.CreateLinkedTokenSource(cts.Token, _shutdownCts.Token); | ||
| var dashboardResourceTasks = new Dictionary<string, Task>(); |
There was a problem hiding this comment.
I think this should be case insesntive. I'm not sure if there is a scenario where the resource service reports the same resource with different casing, but better safe than sorry?
Suggested change
| var dashboardResourceTasks = new Dictionary<string, Task>(); | |
| var dashboardResourceTasks = new Dictionary<string, Task>(StringComparers.ResourceName); |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3612
Microsoft Reviewers: Open in CodeFlow