Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CosmosDb EF API #2215

Merged
merged 5 commits into from
Feb 15, 2024
Merged

Update CosmosDb EF API #2215

merged 5 commits into from
Feb 15, 2024

Conversation

sebastienros
Copy link
Member

@sebastienros sebastienros commented Feb 14, 2024

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Feb 14, 2024
sebastienros and others added 4 commits February 14, 2024 15:05
…ireAzureEFCoreCosmosDBExtensions.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…ireAzureEFCoreCosmosDBExtensions.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
…ireAzureEFCoreCosmosDBExtensions.cs

Co-authored-by: Eric Erhardt <eric.erhardt@microsoft.com>
@sebastienros sebastienros enabled auto-merge (squash) February 14, 2024 23:23
@sebastienros sebastienros merged commit 5f19c77 into main Feb 15, 2024
8 checks passed
@sebastienros sebastienros deleted the sebros/cosmosefapi branch February 15, 2024 00:08
@@ -57,6 +65,8 @@ And then the connection string will be retrieved from the `ConnectionStrings` co
}
```

The `EnrichCosmosDbContext` won't make use of the `ConnectionStrings`, `Region` and `AccountEndpoint` configuration section since it expects a `DbContext` to be registered at the point it is called.

See the [ConnectionString documentation](https://learn.microsoft.com/azure/cosmos-db/nosql/how-to-dotnet-get-started#connect-with-a-connection-string) for more information.

### Use configuration providers
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The example below still references "DbContextPooling"

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks - #2381

@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants