Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove DbContextPooling from appsettings tests and docs #2381

Merged
merged 1 commit into from
Feb 23, 2024

Conversation

eerhardt
Copy link
Member

@eerhardt eerhardt commented Feb 23, 2024

This setting is no longer valid.

Microsoft Reviewers: Open in CodeFlow

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-integrations Issues pertaining to Aspire Integrations packages label Feb 23, 2024
@@ -99,7 +98,7 @@ Also you can pass the `Action<EntityFrameworkCoreCosmosDBSettings> configureSett
or

```csharp
builder.EnrichCosmosDbContext<MyDbContext>(settings => settings.HealthChecks = false);
builder.EnrichCosmosDbContext<MyDbContext>(settings => settings.Tracing = false);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

note that Cosmos doesn't have a health check.

@eerhardt eerhardt mentioned this pull request Feb 23, 2024
@eerhardt eerhardt merged commit 7590f58 into dotnet:main Feb 23, 2024
8 checks passed
@eerhardt eerhardt deleted the FixREADME branch February 23, 2024 17:53
@github-actions github-actions bot locked and limited conversation to collaborators Apr 21, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area-integrations Issues pertaining to Aspire Integrations packages
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants