Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable dotnet watch Hot Reload #6090

Merged
merged 1 commit into from
Oct 4, 2024
Merged

Enable dotnet watch Hot Reload #6090

merged 1 commit into from
Oct 4, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 3, 2024

Description

Allows dotnet-watch to enable Hot Reload for the projects.

Follow up on dotnet/sdk#43884

Fixes # (issue)

Checklist

  • Is this feature complete?
    • Yes. Ready to ship.
    • No. Follow-up changes expected.
  • Are you including unit tests for the changes and scenario tests if relevant?
    • Yes
    • No
  • Did you add public API?
    • Yes
      • If yes, did you have an API Review for it?
        • Yes
        • No
      • Did you add <remarks /> and <code /> elements on your triple slash comments?
        • Yes
        • No
    • No
  • Does the change make any security assumptions or guarantees?
    • Yes
      • If yes, have you done a threat model and had a security review?
        • Yes
        • No
    • No
  • Does the change require an update in our Aspire docs?
    • Yes
      • Link to aspire-docs issue:
    • No

@dotnet-policy-service dotnet-policy-service bot added the community-contribution Indicates that the PR has been added by a community member label Oct 3, 2024
@tmat tmat mentioned this pull request Oct 3, 2024
2 tasks
@tmat tmat changed the title Remove Watch=false from ProjectReference Enable Hot Reload via dotnet watch Oct 3, 2024
@tmat tmat changed the title Enable Hot Reload via dotnet watch Enable dotnet watch Hot Reload Oct 3, 2024
@davidfowl
Copy link
Member

@tmat we also need to change this right?

@tmat
Copy link
Member Author

tmat commented Oct 4, 2024

Maybe. Is that branch taken when DCP is present?

@davidfowl
Copy link
Member

Ah you're right, it won't matter here since you are using the IDE protocol.

@davidfowl davidfowl merged commit a65482e into dotnet:main Oct 4, 2024
9 checks passed
@tmat tmat mentioned this pull request Oct 8, 2024
2 tasks
@tmat tmat deleted the Watch9 branch October 17, 2024 17:23
@github-actions github-actions bot locked and limited conversation to collaborators Nov 17, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
community-contribution Indicates that the PR has been added by a community member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants