Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement support for Aspire #43884

Closed
wants to merge 4 commits into from
Closed

Implement support for Aspire #43884

wants to merge 4 commits into from

Conversation

tmat
Copy link
Member

@tmat tmat commented Oct 3, 2024 •
edited
Loading

@tmat tmat requested review from arunchndr and a team as code owners October 3, 2024 20:49
@dotnet-issue-labeler dotnet-issue-labeler bot added Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch untriaged Request triage from a team member labels Oct 3, 2024
@dotnet-policy-service Dotnet Policy Service
Copy link
Contributor

Thanks for your PR, @tmat.
To learn about the PR process and branching schedule of this repo, please take a look at the SDK PR Guide.

@tmat tmat mentioned this pull request Oct 3, 2024
Merged
16 tasks
This was referenced Oct 3, 2024
Open
Open
Open
Open
@tmat
Copy link
Member Author

tmat commented Oct 6, 2024

@phil-allen-msft @davidfowl Ready!

phil-allen-msft
phil-allen-msft reviewed Oct 7, 2024
View reviewed changes
src/BuiltInTools/dotnet-watch/Aspire/AspireServiceFactory.cs
{
IsRootProject = false,
ProjectPath = projectLaunchInfo.ProjectPath,
WorkingDirectory = projectLauncher.EnvironmentOptions.WorkingDirectory, // TODO: Should DCP protocol specify?
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How would we get an answer on these 'TODO' comments?

Copy link
Member Author

@tmat tmat Oct 7, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@davidfowl @karolz-ms

@tmat
Copy link
Member Author

tmat commented Oct 8, 2024

Moving to 9.0.2xx: #43978

@tmat tmat closed this Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@phil-allen-msft phil-allen-msft phil-allen-msft left review comments

@arunchndr arunchndr Awaiting requested review from arunchndr

Assignees
No one assigned
Labels
Area-AspNetCore RazorSDK, BlazorWebAssemblySDK, dotnet-watch Aspire untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tmat @phil-allen-msft @davidfowl