dotnet-watch tests failing

[dsplaisted]

Build Information

Build: https://dev.azure.com/dnceng-public/cbb18261-c48f-4abb-8651-8cdcb5474649/_build/results?buildId=629827
Build error leg or test failing: dotnet-watch.Tests.dll.1.WorkItemExecution
Pull request: #39888

Error Message

##[error].packages/microsoft.dotnet.helix.sdk/8.0.0-beta.24177.1/tools/Microsoft.DotNet.Helix.Sdk.MultiQueue.targets(89,5): error : (NETCORE_ENGINEERING_TELEMETRY=Test) Work item dotnet-watch.Tests.dll.1 in job 82728a56-9430-4356-ab82-1c21670792a7 has failed

{
  "ErrorMessage": "",
  "ErrorPattern": "Work item dotnet-watch\\.Tests\\.dll\\.1 in job [a-z0-9\\-]+ has failed",
  "BuildRetry": true,
  "ExcludeConsoleLog": true
}

Known issue validation

Build: 🔎 https://dev.azure.com/dnceng-public/public/_build/results?buildId=629827
Error message validated: [Work item dotnet-watch\.Tests\.dll\.1 in job [a-z0-9\-]+ has failed]
Result validation: ✅ Known issue matched with the provided build.
Validation performed at: 4/4/2024 9:51:10 AM UTC

Report

Build	Definition	Step Name	Console log	Pull Request
813521	dotnet/sdk	Run TestBuild Tests	Log	#43585
2542439	dotnet-sdk	Run Tests in Helix	Log	#43039
812555	dotnet/sdk	Run TestBuild Tests	Log	#43368
807252	dotnet/sdk	Run TestBuild Tests	Log	#43393
806799	dotnet/sdk	Run Tests in Helix and non Helix in parallel	Log	#43395
806791	dotnet/sdk	Run Tests in Helix and non Helix in parallel	Log	#43394
805272	dotnet/sdk	Run TestBuild Tests	Log	#43359
805663	dotnet/sdk	Run TestBuild Tests	Log	#42718
2536293	dotnet-sdk	Run Tests in Helix	Log	#42743
804527	dotnet/sdk	Run Tests in Helix	Log
804186	dotnet/sdk	Run FullFramework Tests	Log	#43324
804071	dotnet/sdk	Run FullFramework Tests	Log	#42718
802849	dotnet/sdk	Run TestBuild Tests	Log	#42718
801790	dotnet/sdk	Run TestBuild Tests	Log	#43255
799858	dotnet/sdk	Run TestBuild Tests	Log	#43256
799855	dotnet/sdk	Run TestBuild Tests	Log	#43213
797135	dotnet/sdk	Run TestBuild Tests	Log	#43200
795967	dotnet/sdk	Run TestBuild Tests	Log	#43152
793930	dotnet/sdk	Run FullFramework Tests	Log	#43137
793309	dotnet/sdk	Run TestBuild Tests	Log	#43105
791336	dotnet/sdk	Run TestBuild Tests	Log	#43036
791331	dotnet/sdk	Run TestBuild Tests	Log	#42514
789917	dotnet/sdk	Run FullFramework Tests	Log	#43031
788661	dotnet/sdk	Run FullFramework Tests	Log	#42959
787159	dotnet/sdk	Run TestBuild Tests	Log	#39268
788957	dotnet/sdk	Run FullFramework Tests	Log	#42652
788969	dotnet/sdk	Run FullFramework Tests	Log	#43011
788829	dotnet/sdk	Run FullFramework Tests	Log	#43008
788918	dotnet/sdk	Run TestBuild Tests	Log	#42699
788889	dotnet/sdk	Run TestBuild Tests	Log	#42976
788600	dotnet/sdk	Run FullFramework Tests	Log	#43004
788581	dotnet/sdk	Run FullFramework Tests	Log	#43003
788698	dotnet/sdk	Run FullFramework Tests	Log	#43007
788535	dotnet/sdk	Run FullFramework Tests	Log	#43002
788494	dotnet/sdk	Run FullFramework Tests	Log	#42987
788267	dotnet/sdk	Run TestBuild Tests	Log	#42976
788205	dotnet/sdk	Run FullFramework Tests	Log	#42641
788078	dotnet/sdk	Run FullFramework Tests	Log	#42807
788011	dotnet/sdk	Run FullFramework Tests	Log	#42978
788014	dotnet/sdk	Run TestBuild Tests	Log	#42976
787725	dotnet/sdk	Run FullFramework Tests	Log	#42996
788068	dotnet/sdk	Run TestBuild Tests	Log	#42984
787976	dotnet/sdk	Run TestBuild Tests	Log	#42984
787977	dotnet/sdk	Run FullFramework Tests	Log	#42984
787797	dotnet/sdk	Run TestBuild Tests	Log	#42978
786967	dotnet/sdk	Run TestBuild Tests	Log	#42976
787931	dotnet/sdk	Run TestBuild Tests	Log	#42998
787812	dotnet/sdk	Run FullFramework Tests	Log	#42971
787553	dotnet/sdk	Run TestBuild Tests	Log	#42987
787543	dotnet/sdk	Run FullFramework Tests	Log	#42497
786891	dotnet/sdk	Run FullFramework Tests	Log	#42987
787394	dotnet/sdk	Run FullFramework Tests	Log	#42900
787473	dotnet/sdk	Run TestBuild Tests	Log	#42994
787426	dotnet/sdk	Run TestBuild Tests	Log	#42978

Summary

24-Hour Hit Count	7-Day Hit Count	1-Month Count
0	3	54

[marcpopMSFT]

@tmat we still see this fairly frequently. Any luck? Here's a recent one from a codeflow PR:
https://helixre107v0xdeko0k025g8.blob.core.windows.net/dotnet-sdk-refs-pull-41616-merge-58511284b77c40778a/dotnet-watch.Tests.dll.1/1/console.418de7ca.log?helixlogtype=result

[tmat]

No luck yet. This might help: https://github.com/dotnet/sdk/blob/d45e40d665e647804de03d2b4eec2aae9c488cb5/test/dotnet-watch.Tests/xunit.runner.json

It will print out test info every 20 seconds a test is running.

[marcpopMSFT]

@tmat another failure this morning shows a bunch of build processes for watch apps still running... https://helixre107v0xd1eu3ibi6ka.blob.core.windows.net/dotnet-sdk-refs-pull-41958-merge-84357342ee154a5088/dotnet-watch.Tests.dll.2/1/console.3dddc463.log?helixlogtype=result

[tmat]

Looks like that's in 8.0 branch. Porting test diagnostics from 9: #41963

[Forgind]

This has been making one of my PRs fail today, so I looked into it a bit. Based on when this issue was created and which tests are failing, I suspect this PR:
#39618

I asked jasonmalinowski whether the MSBuildWorkspace is supposed to support F# because I'd found a code snippet that suggested that it shouldn't, and he said it doesn't and never did. Did that PR make us use MSBuildWorkspace in a different way than we had before?

[Forgind]

The changes to HotReloadDotNetWatcher look most suspicious to me. It looks like a substantial change to how we call MSBuild.