Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Set dotnet-watch timeout based on XUnitWorkItemTimeout #40028

Merged
merged 6 commits into from
Apr 10, 2024
Merged

Set dotnet-watch timeout based on XUnitWorkItemTimeout #40028

merged 6 commits into from
Apr 10, 2024

Conversation

tmat
Copy link
Member

@tmat tmat commented Apr 5, 2024 •
edited
Loading

To avoid Helix killing the process without actionable information.

Flow the value to the tests via env variable.

Will help investigating issues like #40006

@dotnet-issue-labeler dotnet-issue-labeler bot added Area-Infrastructure untriaged Request triage from a team member labels Apr 5, 2024
@build-analysis build-analysis bot mentioned this pull request Apr 6, 2024
Open
@tmat tmat marked this pull request as ready for review April 10, 2024 16:04
@tmat tmat requested review from arunchndr and a team as code owners April 10, 2024 16:04
@tmat
Copy link
Member Author

tmat commented Apr 10, 2024

@dsplaisted PTAL

@tmat tmat merged commit 5a978c2 into dotnet:main Apr 10, 2024
16 checks passed
@tmat tmat deleted the Timeout branch April 10, 2024 22:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dsplaisted dsplaisted dsplaisted approved these changes

@arunchndr arunchndr Awaiting requested review from arunchndr

Assignees
No one assigned
Labels
Area-Infrastructure untriaged Request triage from a team member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tmat @dsplaisted