Put binlog directly into the VMR's

[Winniexu01]

Fixes dotnet/source-build#4112

Repo logs are stored separately under their repositories, which makes it very inconvenient to check.
So we introduced a new property DotNetBuildArtifactsLogDir which point to artifacts\log\Release\<reponame>\, all repo binlogs and other logs will respect the property and write to that folder.

[ViktorHofer]

Looks good. A few more changes are necessary. I couldn't directly commit to your branch. Please apply this patch:

diff --git a/eng/pipelines/templates/jobs/vmr-build.yml b/eng/pipelines/templates/jobs/vmr-build.yml
index 4490d6ba8c..742bdb494c 100644
--- a/eng/pipelines/templates/jobs/vmr-build.yml
+++ b/eng/pipelines/templates/jobs/vmr-build.yml
@@ -447,8 +447,6 @@ jobs:
         cd "$(sourcesPath)"
 
         CopyWithRelativeFolders "artifacts/log/"             $targetFolder "*"
-        CopyWithRelativeFolders "src/"                       $targetFolder "*.binlog"
-        CopyWithRelativeFolders "src/"                       $targetFolder "*.log"
 
         if (Test-Path "artifacts/scenario-tests/") {
             CopyWithRelativeFolders "artifacts/scenario-tests/" $targetFolder "*.binlog"
@@ -486,11 +484,14 @@ jobs:
         fi
 
         cd "$(sourcesPath)"
+
         find artifacts/log/ -exec rsync -R {} -t ${targetFolder} \;
+
         if [ -d "artifacts/scenario-tests/" ]; then
           find artifacts/scenario-tests/ -type f -name "*.binlog" -exec rsync -R {} -t ${targetFolder} \;
           echo "##vso[task.setvariable variable=hasScenarioTestResults]true"
         fi
+
         find artifacts/TestResults/ -type f -name "*.binlog" -exec rsync -R {} -t ${targetFolder} \;
         find artifacts/TestResults/ -type f -name "*.diff" -exec rsync -R {} -t ${targetFolder} \;
         find artifacts/TestResults/ -type f -name "Updated*.txt" -exec rsync -R {} -t ${targetFolder} \;
@@ -498,12 +499,8 @@ jobs:
 
         if [[ "${{ parameters.buildSourceOnly }}" == "True" ]]; then
           find artifacts/prebuilt-report/ -exec rsync -R {} -t ${targetFolder} \;
-          find artifacts/log/binary-report/ -exec rsync -R {} -t ${targetFolder} \;
         fi
 
-        find src/ -type f -name "*.binlog" -exec rsync -R {} -t ${targetFolder} \;
-        find src/ -type f -name "*.log" -exec rsync -R {} -t ${targetFolder} \;
-
         # check if we have assets to publish
         if [ -n "$(ls -A 'artifacts/assets/Release/')" ]; then
           echo "##vso[task.setvariable variable=hasAssets]true"
diff --git a/src/SourceBuild/content/repo-projects/Directory.Build.targets b/src/SourceBuild/content/repo-projects/Directory.Build.targets
index 7643084ca8..707578e3b7 100644
--- a/src/SourceBuild/content/repo-projects/Directory.Build.targets
+++ b/src/SourceBuild/content/repo-projects/Directory.Build.targets
@@ -513,22 +513,16 @@
 
   <Target Name="CopyDotNetBuildArtifactsLogs"
         Condition="'$(IsUtilityProject)' != 'true' and
-                    Exists('$(ProjectDirectory)artifacts')">    
-
+                    Exists('$(ProjectDirectory)artifacts')">
     <ItemGroup>
       <LogFilesToCopy Include="$(ProjectDirectory)artifacts/**/*.log" />
       <LogFilesToCopy Include="$(ProjectDirectory)artifacts/**/*.binlog" />
-    </ItemGroup>  
-    
+    </ItemGroup>
+
     <!-- Make a copy of the build logs -->
     <Copy SourceFiles="@(LogFilesToCopy)"
           DestinationFolder="$(DotNetBuildArtifactsLogDir)"
           Condition="'@(LogFilesToCopy)' != ''" />
-
-    <!-- Cleanup build logs -->
-    <Delete Files="@(LogFilesToCopy)" Condition="'@(LogFilesToCopy)' != ''" />
-    <Message Text="Files deleted: @(LogFilesToCopy)"/>
-  
   </Target>
 
   <Target Name="CleanupRepo"

[Winniexu01]

Sure, I've updated the code with the patch.

[ViktorHofer]

This looks great. Thanks a lot.

[Winniexu01]

/backport to release/9.0.1xx

[github-actions]

Started backporting to release/9.0.1xx: https://github.com/dotnet/sdk/actions/runs/10806681930