-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[main] Update dependencies from dotnet/arcade #42900
[main] Update dependencies from dotnet/arcade #42900
Conversation
…820.6 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24416.2 -> To Version 9.0.0-beta.24420.6
…821.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24420.6 -> To Version 9.0.0-beta.24421.2
…e075de8-51b0-42ab-9119-2ac422e989df
…821.7 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24421.2 -> To Version 9.0.0-beta.24421.7
This is complaining about 11 new prebuilts:
@dotnet/source-build-internal Can you fix / route appropriately? |
Looking |
This is a result of dotnet/arcade#15010 - we have 6.8.1 versions of these packages in SBRP but not 6.11.0. I'll look into adding these to SBRP for main and 9.0 branches. These weren't caught as prebuilts in arcade because we currently have an exclusion there for nuget: https://github.com/dotnet/arcade/blob/c8b7f328217240087a32e5dc9877b616ed96b7d8/eng/SourceBuildPrebuiltBaseline.xml#L7 |
…823.2 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24421.7 -> To Version 9.0.0-beta.24423.2
Fix has been merged - once the SBRP reference is updated in sdk, merge in main and the prebuilt errors should be resolved. |
…826.3 Microsoft.SourceBuild.Intermediate.arcade , Microsoft.DotNet.Arcade.Sdk , Microsoft.DotNet.Build.Tasks.Installers , Microsoft.DotNet.Helix.Sdk , Microsoft.DotNet.SignTool , Microsoft.DotNet.XliffTasks , Microsoft.DotNet.XUnitExtensions From Version 9.0.0-beta.24423.2 -> To Version 9.0.0-beta.24426.3
I'm not sure I follow. I know something was fixed in Arcade, but are you saying we also need to make a change in the SDK, or just wait for Arcade to flow, or what? Thanks. |
Yes, we need to update the SBRP reference in sdk in order to fix the errors. In short, some packages were bumped in arcade and because SBRP did not contain those packages, they were detected as prebuilts when building the VMR. The fix was to add these packages to SBRP + then flow that into sdk (since the VMR builds out of SDK). #43019 contains the fix from SBRP, so we need that be merged to fix the issues in this PR. |
…e075de8-51b0-42ab-9119-2ac422e989df
This pull request updates the following dependencies
From https://github.com/dotnet/arcade