Revert skipping of MusicStore tests #12097
Assignees
Labels
Done
This issue has been fixed
Comments
dougbu
added a commit
that referenced
this issue
Jul 11, 2019
ajcvickers
added a commit
that referenced
this issue
Jul 11, 2019
Fixes #12097 The issue here is that the tests were incorrectly creating multiple instances of the same entity. This was being masked by a bug in EF which has just been fixed. The fix here is to not try to track multiple instances with the same ID.
Merged
ajcvickers
added a commit
to dotnet/efcore
that referenced
this issue
Jul 11, 2019
Would have allowed us to catch issues like dotnet/aspnetcore#12097 Part of #11838 Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements. I intend to add some more tests here before 3.0 to get some more coverage.
dougbu
pushed a commit
that referenced
this issue
Jul 11, 2019
* Update dependencies from https://github.com/dotnet/roslyn build 20190709.5 - Microsoft.Net.Compilers.Toolset - 3.3.0-beta2-19359-05 * Skip three failing MusicStore tests - see #12097 * Update dependencies from https://github.com/aspnet/AspNetCore-Tooling build 20190711.5 - Microsoft.NET.Sdk.Razor - 3.0.0-preview8.19361.5 - Microsoft.CodeAnalysis.Razor - 3.0.0-preview8.19361.5 - Microsoft.AspNetCore.Razor.Language - 3.0.0-preview8.19361.5 - Microsoft.AspNetCore.Mvc.Razor.Extensions - 3.0.0-preview8.19361.5 * Update dependencies from https://github.com/aspnet/EntityFrameworkCore build 20190711.7 - Microsoft.EntityFrameworkCore.Tools - 3.0.0-preview8.19361.7 - Microsoft.EntityFrameworkCore.SqlServer - 3.0.0-preview8.19361.7 - dotnet-ef - 3.0.0-preview8.19361.7 - Microsoft.EntityFrameworkCore - 3.0.0-preview8.19361.7 - Microsoft.EntityFrameworkCore.InMemory - 3.0.0-preview8.19361.7 - Microsoft.EntityFrameworkCore.Relational - 3.0.0-preview8.19361.7 - Microsoft.EntityFrameworkCore.Sqlite - 3.0.0-preview8.19361.7 Dependency coherency updates - Microsoft.AspNetCore.Analyzer.Testing - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.AspNetCore.BenchmarkRunner.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ActivatorUtilities.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.Memory - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.SqlServer - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Caching.StackExchangeRedis - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.CommandLineUtils.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.AzureKeyVault - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Binder - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.CommandLine - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.EnvironmentVariables - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.FileExtensions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Ini - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Json - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.KeyPerFile - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.UserSecrets - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration.Xml - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Configuration - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyInjection.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyInjection - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DiagnosticAdapter - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Diagnostics.HealthChecks.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Diagnostics.HealthChecks - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Composite - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Embedded - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileProviders.Physical - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.FileSystemGlobbing - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.HashCodeCombiner.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Hosting.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Hosting - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.HostFactoryResolver.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Http - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Localization.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Localization - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Abstractions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.AzureAppServices - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Configuration - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Console - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Debug - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.EventSource - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.EventLog - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.TraceSource - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Logging.Testing - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ObjectPool - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options.ConfigurationExtensions - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options.DataAnnotations - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Options - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ParameterDefaultValue.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.Primitives - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.TypeNameHelper.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.ValueStopwatch.Sources - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.WebEncoders - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Internal.Extensions.Refs - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.JSInterop - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Mono.WebAssembly.Interop - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Bcl.AsyncInterfaces - 1.0.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.CSharp - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Win32.Registry - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Win32.SystemEvents - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.ComponentModel.Annotations - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Diagnostics.EventLog - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Drawing.Common - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.IO.Pipelines - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Net.Http.WinHttpHandler - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Net.WebSockets.WebSocketProtocol - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Reflection.Metadata - 1.7.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Runtime.CompilerServices.Unsafe - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Cng - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Pkcs - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Security.Cryptography.Xml - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Security.Permissions - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Security.Principal.Windows - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.ServiceProcess.ServiceController - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Text.Encodings.Web - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Text.Json - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Threading.Channels - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - System.Windows.Extensions - 4.6.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.Extensions.DependencyModel - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.NETCore.App.Ref - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - NETStandard.Library.Ref - 2.1.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.NETCore.Platforms - 3.0.0-preview8.19361.1 (parent: Microsoft.NETCore.App.Runtime.win-x64) - Microsoft.NETCore.App.Runtime.win-x64 - 3.0.0-preview8-27911-04 (parent: Microsoft.Extensions.Logging) - Microsoft.Extensions.Logging - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Internal.AspNetCore.Analyzers - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore) - Microsoft.AspNetCore.Testing - 3.0.0-preview8.19361.5 (parent: Microsoft.EntityFrameworkCore)
ajcvickers
added a commit
to dotnet/efcore
that referenced
this issue
Jul 11, 2019
Would have allowed us to catch issues like dotnet/aspnetcore#12097 Part of #11838 Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements. I intend to add some more tests here before 3.0 to get some more coverage.
ajcvickers
added a commit
that referenced
this issue
Jul 12, 2019
Fixes #12097 The issue here is that the tests were incorrectly creating multiple instances of the same entity. This was being masked by a bug in EF which has just been fixed. The fix here is to not try to track multiple instances with the same ID.
ghost
locked as resolved and limited conversation to collaborators
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Affected tests are all in
MusicStore.Controllers.ShoppingCartControllerTest:AddToCart_AddsItemToCartRemoveFromCart_RemovesItemFromCartIndex_ReturnsCartItems_WhenItemsInCartSee three skips that are soon-to-be added to #12042 for more information.
The text was updated successfully, but these errors were encountered: