Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add EF tests that use the Identity model #11838

Closed
ajcvickers opened this issue Apr 27, 2018 · 0 comments · Fixed by #23723
Closed

Add EF tests that use the Identity model #11838

ajcvickers opened this issue Apr 27, 2018 · 0 comments · Fixed by #23723
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.2 punted-for-3.1 type-enhancement
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

Model could be copied, or could be referenced directly from Identity package in our tests. After thinking about doing this on either the Identity side or the EF side I think having the tests on the EF side makes more sense since they can easily be setup to run as spec tests for all EF providers.
@ajcvickers ajcvickers self-assigned this Apr 27, 2018
@ajcvickers ajcvickers added this to the 2.2.0 milestone Apr 27, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0-preview2, 2.2.0 Sep 11, 2018
@ajcvickers ajcvickers modified the milestones: 2.2.0, 3.0.0 Oct 1, 2018
@ajcvickers ajcvickers modified the milestones: 3.0.0, Backlog Jan 28, 2019
ajcvickers added a commit that referenced this issue Jul 11, 2019
@ajcvickers
Added some infrastructure and coverage for ASP.NET models
ce032e0 
Would have allowed us to catch issues like dotnet/aspnetcore#12097

Part of #11838

Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements.

I intend to add some more tests here before 3.0 to get some more coverage.
@ajcvickers ajcvickers mentioned this issue Jul 11, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 11, 2019
@ajcvickers
Added some infrastructure and coverage for ASP.NET models
4c0cb15 
Would have allowed us to catch issues like dotnet/aspnetcore#12097

Part of #11838

Ideally, we should reference the actual "product" assemblies, but this requires changes to dependencies that I don't want to take on write now. #11838 is still open to track improvements.

I intend to add some more tests here before 3.0 to get some more coverage.
ajcvickers added a commit that referenced this issue Jul 14, 2019
@ajcvickers
Add more MusicStore and Identity tests
53c3500 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
@ajcvickers ajcvickers mentioned this issue Jul 14, 2019
Merged
ajcvickers added a commit that referenced this issue Jul 15, 2019
@ajcvickers
Add more MusicStore and Identity tests
865b861 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
ajcvickers added a commit that referenced this issue Jul 15, 2019
@ajcvickers
Add more MusicStore and Identity tests
dbf76eb 
Covering all the queries MusicStore does, and also updating the tests to properly use store-generated values.

Also, added the ModelSnapshots generated by the project templates for 2.1, 2.2, and 3.0, for SQL Server and SQLite. They all diff correctly against the current code showing no differences in the generated schema.

Part of #15662 and #11838

Note that currently the ASP.NET 3.0 templates still contain migrations generated by 2.2. See dotnet/aspnetcore#12168
@ajcvickers ajcvickers added the good first issue This issue should be relatively straightforward to fix. label Sep 2, 2019
@ajcvickers ajcvickers modified the milestones: Backlog, 3.1.0 Sep 4, 2019
@ajcvickers ajcvickers modified the milestones: 3.1.0, Backlog Oct 11, 2019
@ajcvickers ajcvickers mentioned this issue Apr 6, 2020
Closed
@ajcvickers ajcvickers modified the milestones: Backlog, MQ Sep 11, 2020
ajcvickers added a commit that referenced this issue Dec 17, 2020
@ajcvickers
Add testing for ASP.NET Core Identity model
3ba6898 
Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:
* The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
* The queries issues by Identity continue to work in new versions and across providers
* The common (documented) customizations of the Identity model continue to work
@ajcvickers ajcvickers modified the milestones: MQ, 6.0.0 Dec 17, 2020
@ajcvickers ajcvickers added closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. and removed good first issue This issue should be relatively straightforward to fix. labels Dec 17, 2020
@ajcvickers ajcvickers mentioned this issue Dec 17, 2020
Merged
ajcvickers added a commit that referenced this issue Dec 18, 2020
@ajcvickers
Add testing for ASP.NET Core Identity model
1ebb947 
Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:
* The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
* The queries issues by Identity continue to work in new versions and across providers
* The common (documented) customizations of the Identity model continue to work
ajcvickers added a commit that referenced this issue Dec 19, 2020
@ajcvickers
Add testing for ASP.NET Core Identity model
bc2fdb5 
Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:
* The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
* The queries issues by Identity continue to work in new versions and across providers
* The common (documented) customizations of the Identity model continue to work
ajcvickers added a commit that referenced this issue Dec 19, 2020
@ajcvickers
Add testing for ASP.NET Core Identity model (#23723)
a48bfd1 
Fixes #11838

The intention here is not to test ASP.NET Core Identity. It is instead to test that:
* The Identity model continues to build correctly with new versions of EF Core and across multipler providers, including external providers once they adopt these tests
* The queries issues by Identity continue to work in new versions and across providers
* The common (documented) customizations of the Identity model continue to work
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-preview1 Jan 27, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-preview1, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-test closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. punted-for-2.2 punted-for-3.1 type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add testing for ASP.NET Core Identity model dotnet/efcore
3 participants
@divega @ajcvickers @AndriySvyryd