Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove obsolete IHttpBufferingFeature, IHttpSendFileFeature #28890

Merged
1 commit merged into from
Dec 29, 2020
Merged

Remove obsolete IHttpBufferingFeature, IHttpSendFileFeature #28890

1 commit merged into from
Dec 29, 2020

Conversation

Tratcher
Copy link
Member

#27529

Obsolete types in Http:

  • IHttpBufferingFeature: Obsolete since 3.0. No longer works. Removing.
  • IHttpSendFileFeature: Obsolete since 3.0. No longer works. Removing.
  • IHttpResponseFeature.Body: Obsolete since 3.0. Not directly consumed by most developers. It's part of an interface so removing it is more impactful. I'll leave it for now.

@Tratcher Tratcher self-assigned this Dec 28, 2020
@ghost ghost added the area-servers label Dec 28, 2020
pranavkm
pranavkm reviewed Dec 29, 2020
View reviewed changes
src/Http/Http.Features/src/PublicAPI.Shipped.txt
@@ -61,9 +61,6 @@ Microsoft.AspNetCore.Http.Features.IFormFeature.ReadFormAsync(System.Threading.C
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.get -> bool
Microsoft.AspNetCore.Http.Features.IHttpBodyControlFeature.AllowSynchronousIO.set -> void
Microsoft.AspNetCore.Http.Features.IHttpBufferingFeature
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are there no concrete implementations for these feature?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, they were replaced in 3.0 by IHttpResponseBodyFeature.

@Tratcher Tratcher force-pushed the tratcher/http/obsolete branch from f5d23e0 to 72b1ffa Compare December 29, 2020 18:40
@ghost
Copy link

ghost commented Dec 29, 2020

Hello @Tratcher!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@Tratcher Tratcher added this to the 6.0-preview1 milestone Dec 29, 2020
@ghost ghost merged commit 674662d into dotnet:master Dec 29, 2020
@Tratcher Tratcher deleted the tratcher/http/obsolete branch December 29, 2020 20:21
@Tratcher Tratcher mentioned this pull request Dec 29, 2020
Closed
@amcasey amcasey added area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions and removed area-runtime labels Jun 6, 2023
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jkotalik jkotalik jkotalik approved these changes

@pranavkm pranavkm pranavkm approved these changes

@halter73 halter73 Awaiting requested review from halter73

@captainsafia captainsafia Awaiting requested review from captainsafia

Assignees

@Tratcher Tratcher

Labels
area-networking Includes servers, yarp, json patch, bedrock, websockets, http client factory, and http abstractions
Projects
None yet
Milestone
6.0-preview1
Development

Successfully merging this pull request may close these issues.
4 participants
@Tratcher @pranavkm @jkotalik @amcasey