Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update area-owners.md #49229

Merged
merged 9 commits into from
Jul 11, 2023
Merged

Update area-owners.md #49229

merged 9 commits into from
Jul 11, 2023

Conversation

danmoseley
Copy link
Member

@danmoseley danmoseley commented Jul 5, 2023

@mkArtakMSFT @adityamandaleeka @joperezr I noticed some of this is out of date.

Can we pull content in from https://github.com/dotnet/aspnetcore-internal/wiki/Team-Ownership and delete the internal page? I'm happy to do this but where is, eg., the list of triagers for gRPC defined?

cc @ericstj @jeffhandley

Edit: Preview - https://github.com/dotnet/aspnetcore/blob/danmoseley-patch-1/docs/area-owners.md

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 5, 2023
@ghost
Copy link

ghost commented Jul 5, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@danmoseley
Copy link
Member Author

BTW the runtime team differentiates leads from owners, and also has GitHub teams set up for each one. We don't need to do those things, but I do like having IC's listed here rather than only leads.

@@ -6,8 +6,8 @@ The below table lists all the `area-`labels used in the `aspnetcore` repository
|--- | ---| --- |
| area-blazor | mkArtakMSFT | Blazor server and Blazor WASM related |
| area-commandlinetools | mkArtakMSFT | dev certs, dotnet watch, |
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this correct? @mkArtak

Copy link
Member

@javiercn javiercn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just one potentially unrelated change.

@danmoseley
Copy link
Member Author

I've updated the table to add missing areas, add hyperlinks, and distinguish leads from owners. It would be great to have engineers listed here. I think @adityamandaleeka is going to add his.

@danmoseley
Copy link
Member Author

added our team of community triagers

@mitchdenny
Copy link
Member

Looping @amcasey and @captainsafia into this conversation. We should probably add our triagers list to the list of owners in this table. For minimal you could put @captainsafia and @mitchdenny as owners since we mostly do the triage there. You can put us down for middleware as well.

@amcasey
Copy link
Member

amcasey commented Jul 7, 2023

Looping @amcasey and @captainsafia into this conversation. We should probably add our triagers list to the list of owners in this table. For minimal you could put @captainsafia and @mitchdenny as owners since we mostly do the triage there. You can put us down for middleware as well.

Sorry, updating this file was on my todo list when I got pulled off for something urgent. While more updates may come later, you can put me down for area-networking, area-dataprotection, area-commandlinetools, and area-runtime.

@danmoseley
Copy link
Member Author

@amcasey you have the right prioritization 😄 done.

@danmoseley danmoseley requested a review from a team as a code owner July 7, 2023 00:56
@danmoseley
Copy link
Member Author

@wtgodbe can you review the yml here? I was wondering why it hadn't worked -- then realized that of course yml changes trigger validation..

@danmoseley
Copy link
Member Author

##[error]Exit code 134 returned from process: file name '/Users/runner/runners/3.220.5/externals/node16/bin/node', arguments '"/Users/runner/work/_tasks/Bash_6c731c3c-3c68-459a-a5c9-bde6e6595b5b/3.224.0/bash.js"'.

no more info.

@JamesNK
Copy link
Member

JamesNK commented Jul 7, 2023

There are empty cells in the community triagers table.

Screenshot:
image

@danmoseley
Copy link
Member Author

danmoseley commented Jul 7, 2023

There are empty cells in the community triagers table.

Github markdown flavor does not support headerless tables. This is the only way to lay stuff out horizontally (not that it matters ofc)

@JamesNK
Copy link
Member

JamesNK commented Jul 7, 2023

Use a bullet point list?

@captainsafia
Copy link
Member

I've update area ownership for myself and added a row for area-openapi.

I think we can remove area-web-frameworks since it is now defunct.

@danmoseley
Copy link
Member Author

@mkArtakMSFT OK with me removing area-webframeworks? I looked and it seems everything falls under some other area- label. It really was a team label, which is orthogonal

@danmoseley
Copy link
Member Author

Ideally we'd have 2-3 engineers for each row.
Who tends to most often look at security stuff, beyond @blowdart ?

@danmoseley
Copy link
Member Author

I'm going to merge this for now (nice to have the yaml changes) and let's continue to fill this out..

@danmoseley danmoseley merged commit 2849b4c into main Jul 11, 2023
26 checks passed
@danmoseley danmoseley deleted the danmoseley-patch-1 branch July 11, 2023 16:32
@ghost ghost added this to the 8.0-preview7 milestone Jul 11, 2023
@@ -17,6 +17,15 @@ pr:
branches:
include:
- '*'
paths:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I missed this - I believe it'll make such PRs require a force-merge from someone with admin permissions, since this pipeline is a required check. Last time we tried this it didn't work, since github interprets a required check as "Must pass", and not "Must pass if it runs". We'll see on #49331

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants