-
Notifications
You must be signed in to change notification settings - Fork 10k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update area-owners.md #49229
Update area-owners.md #49229
Conversation
Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at. |
BTW the runtime team differentiates leads from owners, and also has GitHub teams set up for each one. We don't need to do those things, but I do like having IC's listed here rather than only leads. |
docs/area-owners.md
Outdated
@@ -6,8 +6,8 @@ The below table lists all the `area-`labels used in the `aspnetcore` repository | |||
|--- | ---| --- | | |||
| area-blazor | mkArtakMSFT | Blazor server and Blazor WASM related | | |||
| area-commandlinetools | mkArtakMSFT | dev certs, dotnet watch, | |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this correct? @mkArtak
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, just one potentially unrelated change.
I've updated the table to add missing areas, add hyperlinks, and distinguish leads from owners. It would be great to have engineers listed here. I think @adityamandaleeka is going to add his. |
added our team of community triagers |
Looping @amcasey and @captainsafia into this conversation. We should probably add our triagers list to the list of owners in this table. For minimal you could put @captainsafia and @mitchdenny as owners since we mostly do the triage there. You can put us down for middleware as well. |
Sorry, updating this file was on my todo list when I got pulled off for something urgent. While more updates may come later, you can put me down for |
@amcasey you have the right prioritization 😄 done. |
@wtgodbe can you review the yml here? I was wondering why it hadn't worked -- then realized that of course yml changes trigger validation.. |
no more info. |
Github markdown flavor does not support headerless tables. This is the only way to lay stuff out horizontally (not that it matters ofc) |
Use a bullet point list? |
I've update area ownership for myself and added a row for I think we can remove |
@mkArtakMSFT OK with me removing area-webframeworks? I looked and it seems everything falls under some other area- label. It really was a team label, which is orthogonal |
Ideally we'd have 2-3 engineers for each row. |
I'm going to merge this for now (nice to have the yaml changes) and let's continue to fill this out.. |
@@ -17,6 +17,15 @@ pr: | |||
branches: | |||
include: | |||
- '*' | |||
paths: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I missed this - I believe it'll make such PRs require a force-merge from someone with admin permissions, since this pipeline is a required check. Last time we tried this it didn't work, since github interprets a required check as "Must pass", and not "Must pass if it runs". We'll see on #49331
@mkArtakMSFT @adityamandaleeka @joperezr I noticed some of this is out of date.
Can we pull content in from https://github.com/dotnet/aspnetcore-internal/wiki/Team-Ownership and delete the internal page? I'm happy to do this but where is, eg., the list of triagers for gRPC defined?
cc @ericstj @jeffhandley
Edit: Preview - https://github.com/dotnet/aspnetcore/blob/danmoseley-patch-1/docs/area-owners.md