Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update area-owners.md #49331

Merged
merged 5 commits into from
Jul 11, 2023
Merged

Update area-owners.md #49331

merged 5 commits into from
Jul 11, 2023

Conversation

danmoseley
Copy link
Member

Trivial edit just to start a PR to remind us to fill out the rest of the table when time allows.

cc @adityamandaleeka

@dotnet-issue-labeler dotnet-issue-labeler bot added the area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework label Jul 11, 2023
@ghost
Copy link

ghost commented Jul 11, 2023

Hey @dotnet/aspnet-build, looks like this PR is something you want to take a look at.

@wtgodbe wtgodbe mentioned this pull request Jul 11, 2023
@wtgodbe
Copy link
Member

wtgodbe commented Jul 11, 2023

FYI - https://github.com/dotnet/aspnetcore/pull/49229/files#r1260001315. We'll see what happens when Components finishes

@danmoseley
Copy link
Member Author

@wtgodbe looks like you're right. @jkoritzinsky I guess this isn't an issue in runtime because you don't have any required checks (?)

anyway, even if it's admins only, I'm tempted to think it's still an improvement.

@wtgodbe
Copy link
Member

wtgodbe commented Jul 11, 2023

anyway, even if it's admins only, I'm tempted to think it's still an improvement.

If the goal is to save time, I'm not sure it is, since the question is if you can get a hold of an admin in less time than the CI would normally take. But even if we do still run CI on these PRs, the author still has the option of asking an admin to force-merge it before CI finishes

@jkoritzinsky
Copy link
Member

Yes, we don't have required checks yet in dotnet/runtime, partially because of this exact issue (no concept of "required only if requested to run"). Sadly, GitHub's required checks feature (and as a result the auto-merge feature) is quite limited and not particularly flexible.

@danmoseley
Copy link
Member Author

If the goal is to save time, I'm not sure it is, since the question is if you can get a hold of an admin in less time than the CI would normally take.

I was thinking of saving machine time. But yeah, you're right. We can still merge the linting into the regular checks though. Is that just a matter of removing the file type exclusions I added?

@wtgodbe
Copy link
Member

wtgodbe commented Jul 11, 2023

I was thinking of saving machine time. But yeah, you're right. We can still merge the linting into the regular checks though. Is that just a matter of removing the file type exclusions I added?

Removing the exclusions you added will stop aspnetcore-ci from ever being skipped (I think it's fine/good to keep the ones you added to quarantined-pr, though). What do you mean by "merge the linting into the regular checks"?

docs/area-owners.md Outdated Show resolved Hide resolved
Co-authored-by: Martin Costello <martin@martincostello.com>
@danmoseley
Copy link
Member Author

What do you mean by "merge the linting into the regular checks"?

I meant, we were as before I touched anything, except that if there's any markdown in the PR the linting runs (previously we had no linting) and is required to pass

@danmoseley danmoseley requested review from a team and wtgodbe as code owners July 11, 2023 17:49
@danmoseley
Copy link
Member Author

basically what I just pushed.

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

Copy link
Member

@wtgodbe wtgodbe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well, maybe not, now the linter isn't running. Maybe you need to add back paths: with a **/*

Co-authored-by: Martin Costello <martin@martincostello.com>
@danmoseley
Copy link
Member Author

OK seems to be working now.

@danmoseley danmoseley merged commit 3a026d4 into main Jul 11, 2023
@danmoseley danmoseley deleted the danmoseley-patch-1 branch July 11, 2023 19:43
@ghost ghost added this to the 8.0-preview7 milestone Jul 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area-infrastructure Includes: MSBuild projects/targets, build scripts, CI, Installers and shared framework
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants