Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/6.0] Update the Microsoft.Identity.Web versions used by project templates #58228

Closed
wants to merge 1 commit into from

Conversation

halter73
Copy link
Member

@halter73 halter73 commented Oct 3, 2024

Description

Due to a recent change NuGet restore now shows CVE warnings for transitive packages. This PR updates the Microsoft.Identity.Web version referenced by the ASP.NET Core project templates dependencies to as of now get rid of these warnings.

Customer impact

Fixes warnings on restore/build in ASP.NET Core project templates referencing Microsoft.Identity.Web.

How found

Manual CTI Testing.

Regression

No

Testing

Tested manually.

Risk

Low. These are template-only changes, so the developer can manually change the dependency version if this version breaks their scenario. Manual testing verified the mainline scenario works.

@halter73 halter73 requested a review from wtgodbe as a code owner October 3, 2024 21:01
@dotnet-policy-service dotnet-policy-service bot added this to the 6.0.x milestone Oct 3, 2024
@halter73 halter73 added the Servicing-consider Shiproom approval is required for the issue label Oct 3, 2024
@halter73 halter73 changed the title Update the Microsoft.Identity.Web versions used by project templates [release/6.0] Update the Microsoft.Identity.Web versions used by project templates Oct 3, 2024
@mkArtakMSFT mkArtakMSFT added Servicing-approved Shiproom has approved the issue and removed Servicing-consider Shiproom approval is required for the issue labels Oct 3, 2024
@halter73
Copy link
Member Author

halter73 commented Oct 4, 2024

I'm closing this because the helix tests caught a build failure caused by the obsoletion of IDownstreamWebApi.

Pages/Index.cshtml.cs(13,22): error CS0618: 'IDownstreamWebApi' is obsolete: 'Use IDownstreamApi in Microsoft.Identity.Abstractions, implemented in Microsoft.Identity.Web.DownstreamApi.See aka.ms/id-web-downstream-api-v2 for migration details.'

This didn't catch this with my manual testing, because it didn't use the --called-api-url option that brought in IDownstreamWebApi. I don't think this is an option in VS, but it would break some dotnet new commands.

Create Razor Pages Project with Microsoft identity platform dialog

Fully updating the .NET 6 templates would require backporting #47906 and #48863 at a minimum which makes this much higher risk. Fortunately, this doesn't affect the 8.0 variation of this PR (#58229) since we already have those changes in the release/8.0 branch.

Another option would be adding a transitive reference (e.g. <PackageReference Include="Azure.Identity" Version="1.12.1" />) to project templates, but this has downsides and is something we've managed to avoid so far. I don't think it's worth it considering this only affects new projects targeting .NET 6 which is going out of support.

@halter73 halter73 closed this Oct 4, 2024
@dotnet-policy-service dotnet-policy-service bot modified the milestones: 6.0.x, 6.0.36 Oct 4, 2024
@halter73 halter73 deleted the halter73/miw-update-6.0 branch November 19, 2024 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Servicing-approved Shiproom has approved the issue
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants