Remove DependencyModel's dependency on PlatformAbstractions #5218
Conversation
Working towards #5213
|
@bricelam - looks like this https://github.com/aspnet/EntityFrameworkCore/blob/f38686a5974ab94463ccd68484e9133a13e7e13f/src/EFCore.Sqlite.Core/Infrastructure/SpatialiteLoader.cs#L15 code might be relying on the transitive reference to get to |
src/managed/Microsoft.Extensions.DependencyModel/ApplicationEnvironment.cs
Outdated
Show resolved
Hide resolved
src/managed/Microsoft.Extensions.DependencyModel/ApplicationEnvironment.cs
Show resolved
Hide resolved
| @@ -39,6 +43,7 @@ | |||
| <Otherwise> | |||
| <ItemGroup> | |||
| <PackageReference Include="Newtonsoft.Json" Version="9.0.1" /> | |||
| <PackageReference Include="System.Runtime.InteropServices.RuntimeInformation" Version="4.0.0" /> | |||
There was a problem hiding this comment.
Why was this version selected (2.5 years old) -- because it supports older TFMs?
There was a problem hiding this comment.
Both of these versions are what is used in PlatformAbstractions today, which we were getting through transitive dependencies:
https://www.nuget.org/packages/Microsoft.DotNet.PlatformAbstractions/3.0.0-preview-27324-5
System.AppContext (>= 4.1.0)
System.Collections (>= 4.0.11)
System.IO (>= 4.1.0)
System.IO.FileSystem (>= 4.0.1)
System.Reflection.TypeExtensions (>= 4.1.0)
System.Runtime.Extensions (>= 4.1.0)
System.Runtime.InteropServices (>= 4.1.0)
System.Runtime.InteropServices.RuntimeInformation (>= 4.0.0)
I am keeping these versions the same as they were before my change.
| <ItemGroup Condition=" '$(TargetFramework)' == 'netstandard1.3' Or '$(TargetFramework)' == 'netstandard1.6' "> | ||
| <PackageReference Include="System.AppContext" Version="4.1.0" /> |
There was a problem hiding this comment.
Again I assume these package versions were selected based on best fit.
|
@eerhardt can you comment on @steveharter question about package version? Other stuff is resolved. |
…ore-setup#5218) * Remove DependencyModel's dependency on PlatformAbstractions Working towards dotnet/core-setup#5213 Commit migrated from dotnet/core-setup@e43465a
We are planning on removing PlatformAbstractions. The first step is to remove the dependency on it in DependencyModel. The dependency isn't necessary.
Working towards #5213