Improve CustomAttribute #21832

benaadams · 2019-01-06T14:53:09Z

Contributes to dotnet/wpf#94
Contributes to https://github.com/dotnet/corefx/issues/34283#issuecomment-451015598

Originally started as reducing local scopes in AddCustomAttributes (moving declaration and assignment closer to use; to decrease lifetime) (First commit a43f3d2)

Then tidied up the rest of the file while I was there (Second commit 996bed3)

Including making the following structs readonly CustomAttributeNamedArgument, CustomAttributeTypedArgument, CustomAttributeEncodedArgument, CustomAttributeNamedParameter, CustomAttributeCtorParameter, CustomAttributeType,

Final commit

Total bytes of diff: -602 (-0.02% of base)
    diff is an improvement.

Total byte diff includes -13 bytes from reconciling methods
        Base had    3 unique methods,     2765 unique bytes
        Diff had    4 unique methods,     2752 unique bytes

Top file improvements by size (bytes):
        -602 : System.Private.CoreLib.dasm (-0.02% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
        1665 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct,byref):this (0/1 methods)
        1048 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,byref,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (0/1 methods)
          20 : System.Private.CoreLib.dasm - CustomAttributeRecord:.ctor(int,struct):this (0/1 methods)
          19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeRecord(int,byref,byref):this (0/1 methods)
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
       -1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct):this (1/0 methods)
       -1083 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,struct,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (1/0 methods)
        -218 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
        -121 : System.Private.CoreLib.dasm - CustomAttribute:IsCustomAttributeDefined(ref,int,ref,int,bool):bool
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -23 : System.Private.CoreLib.dasm - CustomAttribute:GetAttributeUsage(ref):ref
         -19 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributes(ref,int):ref
         -19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeProps(int,byref,byref):this (1/0 methods)
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

18 total methods with size differences (13 improved, 5 regressed), 17539 unchanged.

Commit 2

Total bytes of diff: -305 (-0.01% of base)
    diff is an improvement.

Total byte diff includes 0 bytes from reconciling methods
        Base had    0 unique methods,        0 unique bytes
        Diff had    0 unique methods,        0 unique bytes

Top file improvements by size (bytes):
        -305 : System.Private.CoreLib.dasm (-0.01% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
         -97 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

8 total methods with size differences (7 improved, 1 regressed), 17552 unchanged.

Commit 3

Total bytes of diff: -410 (-0.01% of base)
    diff is an improvement.

Total byte diff includes 68 bytes from reconciling methods
        Base had    3 unique methods,     2765 unique bytes
        Diff had    4 unique methods,     2833 unique bytes

Top file improvements by size (bytes):
        -410 : System.Private.CoreLib.dasm (-0.01% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
        1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,byref):this (0/1 methods)
        1048 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,byref,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (0/1 methods)
         116 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributeRecords(ref,int):ref
         102 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeRecord(int,byref):this (0/1 methods)
          20 : System.Private.CoreLib.dasm - CustomAttributeRecord:.ctor(int,struct):this (0/1 methods)
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
       -1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct):this (1/0 methods)
       -1083 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,struct,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (1/0 methods)
        -218 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
        -121 : System.Private.CoreLib.dasm - CustomAttribute:IsCustomAttributeDefined(ref,int,ref,int,bool):bool
         -24 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributes(ref,int):ref
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -23 : System.Private.CoreLib.dasm - CustomAttribute:GetAttributeUsage(ref):ref
         -19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeProps(int,byref,byref):this (1/0 methods)
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

19 total methods with size differences (13 improved, 6 regressed), 17538 unchanged.

Commit 4

Total bytes of diff: -602 (-0.02% of base)
    diff is an improvement.

Total byte diff includes -13 bytes from reconciling methods
        Base had    3 unique methods,     2765 unique bytes
        Diff had    4 unique methods,     2752 unique bytes

Top file improvements by size (bytes):
        -602 : System.Private.CoreLib.dasm (-0.02% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
        1665 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct,byref):this (0/1 methods)
        1048 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,byref,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (0/1 methods)
          20 : System.Private.CoreLib.dasm - CustomAttributeRecord:.ctor(int,struct):this (0/1 methods)
          19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeRecord(int,byref,byref):this (0/1 methods)
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
       -1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct):this (1/0 methods)
       -1083 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,struct,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (1/0 methods)
        -218 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
        -121 : System.Private.CoreLib.dasm - CustomAttribute:IsCustomAttributeDefined(ref,int,ref,int,bool):bool
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -23 : System.Private.CoreLib.dasm - CustomAttribute:GetAttributeUsage(ref):ref
         -19 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributes(ref,int):ref
         -19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeProps(int,byref,byref):this (1/0 methods)
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

18 total methods with size differences (13 improved, 5 regressed), 17539 unchanged.

benaadams · 2019-01-06T16:14:51Z

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Windows_NT arm Cross Debug Innerloop Build

benaadams · 2019-01-06T17:38:14Z

Interesting error on Windows_NT arm; happened previously (before triggering a retest which failed same way)

BUILD: Build succeeded.  Finished at 17:15:38.53
BUILD: Product binaries are available at D:\j\workspace\arm_cross_deb---a3e3dfd4\bin\Product\Windows_NT.arm.Debug
[arm_cross_deb---a3e3dfd4] $ cmd /c call C:\Users\runner\AppData\Local\Temp\jenkins1035483821241007740.bat

D:\j\workspace\arm_cross_deb---a3e3dfd4>powershell -NoProfile -Command "Add-Type -Assembly 'System.IO.Compression.FileSystem';
 [System.IO.Compression.ZipFile]::CreateFromDirectory('.\bin\tests\Windows_NT.arm.Debug',
 '.\bin\tests\tests.zip')" 

 Exception calling "CreateFromDirectory" with "2" argument(s):
 "Operation did not complete successfully because the 
 file contains a virus or potentially unwanted software.
"
At line:1 char:56
+ ... ileSystem'; [System.IO.Compression.ZipFile]::CreateFromDirectory('.\b ...
+                 ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    + CategoryInfo          : NotSpecified: (:) [], MethodInvocationException
    + FullyQualifiedErrorId : IOException
 

D:\j\workspace\arm_cross_deb---a3e3dfd4>exit 1

benaadams · 2019-01-06T18:55:24Z

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test
@dotnet-bot test Windows_NT arm Cross Debug Innerloop Build

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs

benaadams · 2019-01-07T02:56:03Z

Total bytes of diff: -410 (-0.01% of base)
    diff is an improvement.

Total byte diff includes 68 bytes from reconciling methods
        Base had    3 unique methods,     2765 unique bytes
        Diff had    4 unique methods,     2833 unique bytes

Top file improvements by size (bytes):
        -410 : System.Private.CoreLib.dasm (-0.01% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
        1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,byref):this (0/1 methods)
        1048 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,byref,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (0/1 methods)
         116 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributeRecords(ref,int):ref
         102 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeRecord(int,byref):this (0/1 methods)
          20 : System.Private.CoreLib.dasm - CustomAttributeRecord:.ctor(int,struct):this (0/1 methods)
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
       -1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct):this (1/0 methods)
       -1083 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,struct,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (1/0 methods)
        -218 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
        -121 : System.Private.CoreLib.dasm - CustomAttribute:IsCustomAttributeDefined(ref,int,ref,int,bool):bool
         -24 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributes(ref,int):ref
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -23 : System.Private.CoreLib.dasm - CustomAttribute:GetAttributeUsage(ref):ref
         -19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeProps(int,byref,byref):this (1/0 methods)
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

19 total methods with size differences (13 improved, 6 regressed), 17538 unchanged.

benaadams · 2019-01-07T02:57:34Z

CustomAttributeData:GetCustomAttributeRecords regresses from the inline of the larger MetadataImport:GetCustomAttributeRecord(int,byref):this from making CustomAttributeRecord readonly and using its .ctor rather than modifying its properties directly

jkotas · 2019-01-07T03:25:45Z

from making CustomAttributeRecord readonly

To avoid this regression - mark struct CustomAttributeRecord as readonly too; or do not mark the field readonly?

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs

benaadams · 2019-01-07T03:52:11Z

; or do not mark the field readonly?

Yep, only going 50% readonly ConstArray seems to do the trick (as MetadataToken is a single int field so doesn't benefit being passed as in)

Total bytes of diff: -602 (-0.02% of base)
    diff is an improvement.

Total byte diff includes -13 bytes from reconciling methods
        Base had    3 unique methods,     2765 unique bytes
        Diff had    4 unique methods,     2752 unique bytes

Top file improvements by size (bytes):
        -602 : System.Private.CoreLib.dasm (-0.02% of base)

1 total files with size differences (1 improved, 0 regressed), 0 unchanged.

Top method regessions by size (bytes):
        1665 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct,byref):this (0/1 methods)
        1048 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,byref,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (0/1 methods)
          20 : System.Private.CoreLib.dasm - CustomAttributeRecord:.ctor(int,struct):this (0/1 methods)
          19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeRecord(int,byref,byref):this (0/1 methods)
           6 : System.Private.CoreLib.dasm - CustomAttributeTypedArgument:ToString(bool):ref:this

Top method improvements by size (bytes):
       -1663 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref,struct):this (1/0 methods)
       -1083 : System.Private.CoreLib.dasm - CustomAttribute:FilterCustomAttributeRecord(struct,struct,ref,struct,ref,bool,byref,byref,byref,byref,byref):bool (1/0 methods)
        -218 : System.Private.CoreLib.dasm - CustomAttribute:AddCustomAttributes(byref,ref,int,ref,bool,byref)
        -148 : System.Private.CoreLib.dasm - CustomAttributeData:.ctor(ref):this
        -121 : System.Private.CoreLib.dasm - CustomAttribute:IsCustomAttributeDefined(ref,int,ref,int,bool):bool
         -23 : System.Private.CoreLib.dasm - CustomAttributeData:get_ConstructorArguments():ref:this
         -23 : System.Private.CoreLib.dasm - CustomAttribute:GetAttributeUsage(ref):ref
         -19 : System.Private.CoreLib.dasm - CustomAttributeData:GetCustomAttributes(ref,int):ref
         -19 : System.Private.CoreLib.dasm - MetadataImport:GetCustomAttributeProps(int,byref,byref):this (1/0 methods)
         -16 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetMarshalAsCustomAttribute(int,ref):ref
         -13 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetDllImportCustomAttribute(ref):ref
         -10 : System.Private.CoreLib.dasm - PseudoCustomAttribute:GetStructLayoutCustomAttribute(ref):ref
          -4 : System.Private.CoreLib.dasm - CustomAttributeNamedArgument:.ctor(ref,ref):this

18 total methods with size differences (13 improved, 5 regressed), 17539 unchanged.

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs

jkotas

Thanks!

benaadams · 2019-01-07T04:10:55Z

For dotnet/wpf#94 a big chunk is in the ModuleHandle.ResolveMethod QCall (this is a pre-changes trace, prior to various improvements to the managed side)

Though I don't know if its easy to gain anything there.

jkotas · 2019-01-07T04:45:17Z

cc @steveharter

jkotas · 2019-01-07T04:54:02Z

dotnet/wpf#94

This is a combination of:

WPF enumerates attributes on all loaded assemblies.
The build systems like to generate a lot of assembly attributes into each assembly
.NET Core has a lot of little assemblies.
The custom attribute APIs expose resolved types only.

While improving 2., 3. or 4. may help somewhat, it won't really make the problem go away.

(1) is the root cause of the problem. Similar designs are known to scale poorly and always turn into performance bugs (and sometimes correctness or security bugs too). It is where the fix needs to be to make the problem go away. E.g. it can an option that allows you to specify the explicit list of assemblies/types that the Xaml parser needs to worry about.

benaadams · 2019-01-07T08:32:32Z

dotnet/wpf#94

(1) is the root cause of the problem.

Ah yes, looking at the startup costs for EventSources in ASP.NET https://github.com/dotnet/corefx/issues/34283#issuecomment-451015598; ModuleHandle.ResolveMethod doesn't particularly feature (on this PR build)

Callers

Callees

benaadams · 2019-01-07T13:32:37Z

I think Ubuntu arm Cross testing is busted all recent PRs are in a waiting state for them after very many hours

benaadams · 2019-01-07T14:56:11Z

(pending—All nodes of label ‘ubuntu.1404.arm32.open’ are offline)

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs

benaadams · 2019-01-07T18:19:01Z

@dotnet-bot test OSX10.12 x64 Checked Innerloop Build and Test

* Reduce local scopes in AddCustomAttributes * CustomAttribute.cs tidy up * Less struct copies

* Reduce local scopes in AddCustomAttributes * CustomAttribute.cs tidy up * Less struct copies Commit migrated from dotnet/coreclr@e5cb6c3

benaadams added 2 commits January 6, 2019 13:36

Reduce local scopes in AddCustomAttributes

a43f3d2

CustomAttribute.cs tidy up

996bed3

benaadams commented Jan 6, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

benaadams commented Jan 6, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

benaadams commented Jan 6, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

benaadams commented Jan 6, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

Less struct copies

179f76f

jkotas reviewed Jan 7, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs Outdated Show resolved Hide resolved

Feedback

02e910f

jkotas reviewed Jan 7, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs Outdated Show resolved Hide resolved

jkotas approved these changes Jan 7, 2019

View reviewed changes

nit

c8e8199

jkotas reviewed Jan 7, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/MdImport.cs Outdated Show resolved Hide resolved

steveharter reviewed Jan 7, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

steveharter reviewed Jan 7, 2019

View reviewed changes

src/System.Private.CoreLib/src/System/Reflection/CustomAttribute.cs Show resolved Hide resolved

Revert method rename

e4a6dfb

jkotas merged commit e5cb6c3 into dotnet:master Jan 7, 2019

benaadams deleted the AddCustomAttributes branch January 7, 2019 19:55

sandreenko pushed a commit to sandreenko/coreclr that referenced this pull request Jan 8, 2019

Improve CustomAttribute (dotnet#21832)

3270704

* Reduce local scopes in AddCustomAttributes * CustomAttribute.cs tidy up * Less struct copies

JasonBock mentioned this pull request Mar 30, 2019

Eliminate hardcoded DataPortal_XYZ method names MarimerLLC/csla#1102

Closed

benaadams mentioned this pull request Jan 31, 2020

Ubuntu arm Cross testing is paused in all PRs (nodes are offline) dotnet/runtime#11763

Closed

picenka21 pushed a commit to picenka21/runtime that referenced this pull request Feb 18, 2022

Improve CustomAttribute (dotnet/coreclr#21832)

191b892

* Reduce local scopes in AddCustomAttributes * CustomAttribute.cs tidy up * Less struct copies Commit migrated from dotnet/coreclr@e5cb6c3

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Improve CustomAttribute #21832

Improve CustomAttribute #21832

benaadams commented Jan 6, 2019 •

edited

Loading

benaadams commented Jan 6, 2019

benaadams commented Jan 6, 2019 •

edited

Loading

benaadams commented Jan 6, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019 •

edited

Loading

jkotas commented Jan 7, 2019

benaadams commented Jan 7, 2019

jkotas left a comment

benaadams commented Jan 7, 2019 •

edited

Loading

jkotas commented Jan 7, 2019

jkotas commented Jan 7, 2019 •

edited

Loading

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

Improve CustomAttribute #21832

Improve CustomAttribute #21832

Conversation

benaadams commented Jan 6, 2019 • edited Loading

benaadams commented Jan 6, 2019

benaadams commented Jan 6, 2019 • edited Loading

benaadams commented Jan 6, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019 • edited Loading

jkotas commented Jan 7, 2019

benaadams commented Jan 7, 2019

jkotas left a comment

Choose a reason for hiding this comment

benaadams commented Jan 7, 2019 • edited Loading

jkotas commented Jan 7, 2019

jkotas commented Jan 7, 2019 • edited Loading

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 7, 2019

benaadams commented Jan 6, 2019 •

edited

Loading

benaadams commented Jan 6, 2019 •

edited

Loading

benaadams commented Jan 7, 2019 •

edited

Loading

benaadams commented Jan 7, 2019 •

edited

Loading

jkotas commented Jan 7, 2019 •

edited

Loading