Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Build and package System.Runtime.CompilerServices.Unsafe for netcoreapp20 #24565

Closed
jkotas opened this issue Jan 4, 2018 · 4 comments
Closed
Assignees
Milestone

Comments

@jkotas
Copy link
Member

jkotas commented Jan 4, 2018

We would have a performance regression in some of the Unsafe.As methods otherwise. It should build and packaged for netcoreapp2.0 that will cover the live netcoreapp as well.

See https://github.com/dotnet/corefx/pull/25959/files/0c0e5136caec611a7178470ff8fbcaa754ddc1a8#discussion_r159258597 for full discussion.

@jkotas jkotas changed the title Build and package System.Memory for netcoreapp Build and package System.Runtime.CompilerServices.Unsafe for netcoreapp20 Jan 4, 2018
@weshaggard
Copy link
Member

We can add a netcoreapp2.0 configuration but we also need to keep the netcoreapp configuration so we can build the entire netcoreapp vertical against live bits.

@ahsonkhan
Copy link
Member

but we also need to keep the netcoreapp configuration so we can build the entire netcoreapp vertical against live bits

Can you please expand on why we need to do that? It would undo the changes from dotnet/corefx#25959

@jkotas
Copy link
Member Author

jkotas commented Jan 5, 2018

There are two separate things:

  1. System.Runtime.CompilerServices.Unsafe has netcoreapp specific build
  2. System.Runtime.CompilerServices.Unsafe is bundled in .NET Core runtime

dotnet/corefx#25959 reversed both 1 and 2.

This issue is about bringing 1 back, but keeping 2 reversed.

If we do not do this, we will be missing the perf fix here: https://github.com/dotnet/corefx/blob/master/src/System.Runtime.CompilerServices.Unsafe/src/System.Runtime.CompilerServices.Unsafe.il#L269 . AsRef won't be as fast as it can be in .NET Core.

@KrzysztofCwalina
Copy link
Member

@weshaggard is this something you could help us with for the bug bounce this month?

weshaggard referenced this issue in weshaggard/corefx Mar 23, 2018
Add netcoreapp2.0 configuration to package to optimize a few parts
of the Unsafe APIs. https://github.com/dotnet/corefx/issues/26145

Add netcoreapp configuration so that netcoreapp vertical still builds
without needing the netcoreapp2.0 targeting pack.
weshaggard referenced this issue in weshaggard/corefx Mar 23, 2018
Add netcoreapp2.0 configuration to package to optimize a few parts
of the Unsafe APIs. https://github.com/dotnet/corefx/issues/26145

Add netcoreapp configuration so that netcoreapp vertical still builds
without needing the netcoreapp2.0 targeting pack.
@msftgits msftgits transferred this issue from dotnet/corefx Jan 31, 2020
@msftgits msftgits added this to the 2.1.0 milestone Jan 31, 2020
@ghost ghost locked as resolved and limited conversation to collaborators Dec 19, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

5 participants