This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Update Unsafe configuratations #28395
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jkotas
approved these changes
Mar 23, 2018
danmoseley
reviewed
Mar 23, 2018
| netstandard1.0; | ||
| netstandard; | ||
| </BuildConfigurations> | ||
| </Packageconfigurations> |
danmoseley
reviewed
Mar 23, 2018
| @@ -4,10 +4,16 @@ | |||
| <PropertyGroup> | |||
| <DocumentationFile>$(MSBuildThisFileDirectory)System.Runtime.CompilerServices.Unsafe.xml</DocumentationFile> | |||
| <ProjectGuid>{04BA3E3C-6979-4792-B19E-C797AD607F42}</ProjectGuid> | |||
| <IlasmFlags>$(IlasmFlags) -INCLUDE=include\$(TargetGroup)</IlasmFlags> | |||
| <IncludePath>include\$(TargetGroup)</IncludePath> | |||
| <Includepath Condition="'$(TargetGroup)' == 'netcoreapp2.0'">include\netcoreapp</Includepath> | |||
Add netcoreapp2.0 configuration to package to optimize a few parts of the Unsafe APIs. https://github.com/dotnet/corefx/issues/26145 Add netcoreapp configuration so that netcoreapp vertical still builds without needing the netcoreapp2.0 targeting pack.
weshaggard
force-pushed
the
UpdateUnsafeConfigurations
branch
from
768aa11 to
a89fa1b
Compare
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
…nfigurations Update Unsafe configuratations Commit migrated from dotnet/corefx@6f85d0d
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add netcoreapp2.0 configuration to package to optimize a few parts
of the Unsafe APIs. https://github.com/dotnet/corefx/issues/26145
Add netcoreapp configuration so that netcoreapp vertical still builds
without needing the netcoreapp2.0 targeting pack.
Fixes https://github.com/dotnet/corefx/issues/26145
cc @ahsonkhan @jkotas @ericstj