Api diff between 2.2 and 3.0 netcoreapp #3411
Conversation
|
We did a lot of work 🥂 |
|
@cstoner for VB |
I think you @-ed the wrong person. |
|
|
|
|
|
|
|
System.Buffers, System.Text.Json/Serialization, System, System.Text, System.Text.Encodings.Web, System.IO.Pipelines, look good to me. Also skimmed the rest (and the layout/etc.), which seem reasonable. |
| ``` diff | ||
| { | ||
| { | ||
| - namespace System.Runtime.CompilerServices { |
There was a problem hiding this comment.
Did we move System.Runtime.CompilerServices.Unsafein-box? I wasn't aware of this. Is this expected? We still ship the OOB package, but I thought this was a "pure" OOB:
https://github.com/dotnet/corefx/blob/b893e604ce832ccf4e9cbcbdfe0b0ae2b23195bf/src/System.Runtime.CompilerServices.Unsafe/pkg/System.Runtime.CompilerServices.Unsafe.pkgproj#L19
https://github.com/dotnet/corefx/issues/26145#issuecomment-355679947
dotnet/corefx#28395
There was a problem hiding this comment.
We build the same binary to ship both inbox and OOB. There still remains an Internal.Runtime.CompilerServices.Unsafe type in System.Private.CoreLib but we don't unify this type System.Runtime.CompilerServices.Unsafe.
Here is the record of this decision: https://github.com/dotnet/corefx/issues/33508
There was a problem hiding this comment.
@Anipik I don't think it's correct to represent this as a diff. Something is wonky with your method for producing the .md
cc @ahsonkhan @danmosemsft @terrajobst @ericstj @karelz @buyaa-n, @krwq @layomia, @JeremyKuhne, @safern @divega, @ajcvickers,@cheenamalhotra, @David-Engel, @Gary-Zh @wtgodbe, @maryamariyan @carlossanlop @davidsh, @wfurt, @scalablecory, @eiriktsarpalis, @karelz
@tannergooding, @steveharter, @GrabYourPitchforks
@richlander
guys please verify the changes in your area owners.