Skip to content
This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
/ corefx Public archive

Re-enable UAP builds #27531

Merged
merged 12 commits into from
Mar 2, 2018
Merged

Re-enable UAP builds #27531

merged 12 commits into from
Mar 2, 2018

Commits on Mar 1, 2018

  1. Build uapaot System.Numerics.Vectors 

    With `Vector<T>` now residing in System.Private.CoreLib, directly reference System.Private.Corelib instead of contracts just like netcoreapp does.

Add uapaot flavor since System.Private.CoreLib has a different strong name key on that platform.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    614f1ff View commit details
    Browse the repository at this point in the history

  2. Make EnsureExtendedPrefixOverMaxPath available to UAP 

    Add the helper method `System.IO.PathInternal.EnsureExtendedPrefixOverMaxPath` to Common\src\System\IO\PathInternal.Windows.cs. It was previously not visible to UAP since  Common\src\CoreLib\System\IO\PathInternal.Windows.cs is not included in UAP compilation.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    68639e3 View commit details
    Browse the repository at this point in the history

  3. Keep SocketsHttpHandler out of UAP builds 

    SocketsHttpHandler is not supported in uap and is currently leaking into UAP builds since they've been disabled for a few weeks. Adjust the contract so it's not available to UAP, and clean the implementation assembly so SocketsHttpHandler internals don't leak out into HttpClientHandler.Core.cs.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    9d67932 View commit details
    Browse the repository at this point in the history

  4. Fix GetAddrInfoExSupportsOverlapped UAP build break 

    `System.Net.NameResolutionPal.GetAddrInfoExSupportsOverlapped` uses LoadLibraryExW which is not compatible with UAP (which only supports LoadLibrary of DLLs within a container). Refactor the helper so UAP returns false.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    d8b26f8 View commit details
    Browse the repository at this point in the history

  5. Revert "Disable UAP legs per #26802 (dotnet#26822)" 

    This reverts commit 120dce4.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    da98236 View commit details
    Browse the repository at this point in the history

  6. Revert "Disable UAP configurations in all configurations build" 

    This reverts commit 2202b4f.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    04026cf View commit details
    Browse the repository at this point in the history

  7. Revert "Disable UAP official builds (dotnet#26871)" 

    This reverts commit ef79caf.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    244c5f6 View commit details
    Browse the repository at this point in the history

  8. Code Review Feedback 

    - Refactor to remove code duplication in HttpClientHandler.Win32.cs
- Suffix non-UAP source files with.Win32.cs instead of NetCoreApp.cs to follow branch convention
- Fix spacing
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    0b846b1 View commit details
    Browse the repository at this point in the history

  9. Code Review Feedback II 

    - Baseline the ApiCompat and GenFacades failures in System.Runtime.Extensions and System.Threading.ThreadPool.
- Adjust naming of files to match branch conventions
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    0701cea View commit details
    Browse the repository at this point in the history

  10. Missed a spot

    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    1c35e7d View commit details
    Browse the repository at this point in the history

  11. Fix up packaging build 

    Fix up some configuration issues with uap packaging. The CoreFX.Private.TestUtilities packaging needs updated build tools which can map between uwp6.0 and netstandard2.0.

#ifdef out Thread.GetCurrentProcessorId until we get a new System.Private.CoreLib.
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    01311ca View commit details
    Browse the repository at this point in the history

  12. Code Review Feedback III 

    - Fix a couple Nits
- Fix recent commit breaking UAP
    @nattress
    nattress committed Mar 1, 2018
    Configuration menu
    Copy the full SHA
    68ba394 View commit details
    Browse the repository at this point in the history