This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
Optimize SqlClient SNIPacket async paths #34184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stephentoub
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
stephentoub
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
benaadams
changed the title
stephentoub
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
benaadams
force-pushed
the
snipacket-async
branch
from
1922660 to
9adbdcd
Compare
saurabh500
reviewed
Dec 20, 2018
src/System.Data.SqlClient/src/System/Data/SqlClient/SNI/SNIPacket.cs
Outdated
Show resolved
Hide resolved
|
Looks like the netstandard targeted builds of SqlClient are failing. You may need to add the ValueTask specific code in separate files, or #if def them if the #ifdef is small. |
saurabh500
reviewed
Dec 20, 2018
saurabh500
reviewed
Dec 20, 2018
saurabh500
reviewed
Dec 20, 2018
|
Seemed to do the trick; thank you for your help @saurabh500 |
saurabh500
approved these changes
Dec 21, 2018
cheenamalhotra
added a commit
to cheenamalhotra/SqlClient
that referenced
this pull request
Dec 11, 2019
Fixes dotnet#262 by reverting dotnet/corefx#34184 until PR dotnet#335 is ready with complete fix.
This was referenced Dec 11, 2019
cheenamalhotra
added a commit
to dotnet/SqlClient
that referenced
this pull request
Dec 13, 2019
Fixes #262 by reverting dotnet/corefx#34184 until PR #335 is ready with complete fix.
picenka21
pushed a commit
to picenka21/runtime
that referenced
this pull request
Feb 18, 2022
* Optimize SNIPacket async paths * Feedback * NET Core vs NET Std * csproj * Feedback Commit migrated from dotnet/corefx@6870c4e
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For
ReadFromStreamAsync(Stream stream, SNIAsyncCallback callback)await stream.ReadAsync(new Memory<byte>(...))is a more efficient path than
stream.ReadAsync(byte[], ...).ContinueWith(Task => ...)Move
WriteToStreamAsync(Stream stream, ...)away from beingasync void/cc @Wraith2 @saurabh500 @afsanehr @keeratsingh @stephentoub