This repository has been archived by the owner on Jan 23, 2023. It is now read-only.
[release/3.1] Revert async changes in SqlClient to fix deadlock issues #42776
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheenamalhotra
added
the
Servicing-consider
|
We will discuss for 3.1.2 |
David-Engel
approved these changes
Jan 6, 2020
karinazhou
approved these changes
Jan 6, 2020
jamshedd
added
Servicing-approved
|
Approved for March |
|
Moved back to 3.1.2 per tactics. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Port of: dotnet/runtime#778 and dotnet/SqlClient#349
Summary
Fixes issue dotnet/SqlClient#262 where client applications goes to deadlock when performing Async operations.
Customer Impact
High. Random deadlocks occur in client applications and apps stay in hanging state.
Regression?
Yes, with PR #34184
Testing
This issue is hard to reproduce in tests and is currently not reproducible consistently, but a repro has been made available to identify deadlocks, which will be added to Microsoft.Data.SqlClient test lab once it can be consistently reproduced in test lab as well.
Risk
Low: The fix has been verified with repro app and confirms the issue has been fixed.
cc: @danmosemsft @benaadams