Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nameof expressions alternative #250

Merged
merged 3 commits into from
Apr 7, 2021
Merged

Conversation

jskeet
Copy link
Contributor

@jskeet jskeet commented Apr 1, 2021

This is an alternative to #10, which builds on that.

BillWagner and others added 2 commits March 17, 2021 10:40
Work done to date on nameof expressions
Builds on dotnet#10

- Reworded to avoid the "meaning" confusion
- Added examples
@jskeet jskeet added the meeting: discuss This issue should be discussed at the next TC49-TG2 meeting label Apr 1, 2021
Copy link
Contributor

@Nigel-Ecma Nigel-Ecma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, drops some questionable (to me) bits from the MS source :-)

@jskeet jskeet merged commit 1d6805f into dotnet:draft-v6 Apr 7, 2021
@jskeet jskeet deleted the nameof-again branch April 7, 2021 21:11
>
> class Program {
> static void Main() {
> var point = (x: 3, y: 4);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tuple types are not part of C# 6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Well spotted, thanks! I'll leave this in right now, but before merging I'll add a commit to remove it, then create a PR to re-add it for C# 7. (We should potentially show the use of point.Item1 as well.)

@BillWagner BillWagner mentioned this pull request Jul 1, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
meeting: discuss This issue should be discussed at the next TC49-TG2 meeting
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants