Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add f1-keyword for using static combination #21125

Merged
merged 1 commit into from
Oct 16, 2020
Merged

Add f1-keyword for using static combination #21125

merged 1 commit into from
Oct 16, 2020

Conversation

TheSench
Copy link
Contributor

Summary

This PR adds an f1_keyword for the using static directive, allowing the using and static keywords to route here when they are found together as part of that directive.

Fixes part of #20799, Roslyn changes under dotnet/roslyn#48660.

@dotnet-bot dotnet-bot added this to the October 2020 milestone Oct 16, 2020
@TheSench TheSench mentioned this pull request Oct 16, 2020
Merged
BillWagner
BillWagner approved these changes Oct 16, 2020
View reviewed changes
Copy link
Member

@BillWagner BillWagner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for submitting this @TheSench

I've reviewed this, and I'll :shipit: now.

Thanks again.

@BillWagner BillWagner merged commit 073f42b into dotnet:master Oct 16, 2020
@TheSench TheSench deleted the feature/add-using-static-csharp-keyword branch October 16, 2020 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BillWagner BillWagner BillWagner approved these changes

Assignees
No one assigned
Labels
dotnet-csharp/svc lang-reference/subsvc
Projects
None yet
Milestone
October 2020
Development

Successfully merging this pull request may close these issues.
3 participants
@TheSench @BillWagner @dotnet-bot