Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update F1 keywords to detect using static combination #48660

Merged
merged 3 commits into from
Oct 16, 2020
Merged

Update F1 keywords to detect using static combination #48660

merged 3 commits into from
Oct 16, 2020

Conversation

TheSench
Copy link
Contributor

@TheSench TheSench commented Oct 16, 2020 •
edited
Loading

This PR makes the f1 keywords for the using and static keyword detect when they are used together. If they are part of a using static directive, they will route to the using static page, rather than their normal keyword page.

Fixes part of dotnet/docs#20799

Related docs PR:
dotnet/docs#21125

@TheSench TheSench requested a review from a team as a code owner October 16, 2020 03:08
@Dotnet-GitSync-Bot
Copy link
Collaborator

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

@TheSench TheSench mentioned this pull request Oct 16, 2020
Merged
@TheSench
Copy link
Contributor Author

I couldn't figure out the best area label to add to this PR. If you have write-permissions please help me learn by adding exactly one area label.

This should have Area-IDE and Community labels.

@davidwengier davidwengier added Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee. labels Oct 16, 2020
@davidwengier davidwengier self-assigned this Oct 16, 2020
@CyrusNajmabadi
Copy link
Member

Thanks!

@CyrusNajmabadi CyrusNajmabadi merged commit c8f1596 into dotnet:master Oct 16, 2020
@ghost ghost added this to the Next milestone Oct 16, 2020
@TheSench TheSench deleted the feature/f1-help-for-using-static branch October 16, 2020 20:35
@allisonchou allisonchou modified the milestones: Next, 16.9.P2 Nov 24, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@CyrusNajmabadi CyrusNajmabadi CyrusNajmabadi approved these changes

@davidwengier davidwengier davidwengier left review comments

Assignees

@davidwengier davidwengier

Labels
Area-IDE Community The pull request was submitted by a contributor who is not a Microsoft employee.
Projects
None yet
Milestone
16.9.P2
Development

Successfully merging this pull request may close these issues.
5 participants
@TheSench @Dotnet-GitSync-Bot @CyrusNajmabadi @davidwengier @allisonchou