Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make implicit join entity in many to many deterministic #21870

Closed
smitpatel opened this issue Jul 31, 2020 · 0 comments · Fixed by #21959
Closed

Make implicit join entity in many to many deterministic #21870

smitpatel opened this issue Jul 31, 2020 · 0 comments · Fixed by #21959
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Milestone
5.0.0

Comments

@smitpatel
Copy link
Member

Currently we generate name of the join entity type and PK without deterministic order, which means that if entity types are discovered in different order then the name and PK property order could be different.
While other things wouldn't matter much but the name which is needed if you want to access db set of join entity type should remain same.
Probably alphabetical order of entity type names.
@ajcvickers ajcvickers added this to the 5.0.0 milestone Jul 31, 2020
AndriySvyryd added a commit that referenced this issue Aug 6, 2020
@AndriySvyryd
Configure OnDelete for join entity types on SQL Server
4d1792e 
Make join entity type name deterministic

Fixes #21858
Fixes #21870
@AndriySvyryd AndriySvyryd added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 6, 2020
@AndriySvyryd AndriySvyryd removed their assignment Aug 6, 2020
AndriySvyryd added a commit that referenced this issue Aug 6, 2020
@AndriySvyryd
Configure OnDelete for join entity types on SQL Server
1d6b5b7 
Make join entity type name deterministic

Fixes #21858
Fixes #21870
@AndriySvyryd AndriySvyryd mentioned this issue Aug 6, 2020
Merged
@ghost ghost closed this as completed in #21959 Aug 6, 2020
ghost pushed a commit that referenced this issue Aug 6, 2020
@AndriySvyryd
Configure OnDelete for join entity types on SQL Server (#21959)
eb6584f 
* Configure OnDelete for join entity types on SQL Server
Make join entity type name deterministic

Fixes #21858
Fixes #21870

* Use skip navigation name for the implicit FK name

Fixes #21915
@ajcvickers ajcvickers modified the milestones: 5.0.0, 5.0.0-rc1 Aug 14, 2020
@ajcvickers ajcvickers modified the milestones: 5.0.0-rc1, 5.0.0 Nov 7, 2020
This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-model-building closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-bug
Projects
None yet
Milestone
5.0.0
Development

Successfully merging a pull request may close this issue.

Configure OnDelete for join entity types on SQL Server dotnet/efcore
3 participants
@ajcvickers @smitpatel @AndriySvyryd