Configure OnDelete for join entity types on SQL Server #21959
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @AndriySvyryd! Because this pull request has the p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (
|
smitpatel
reviewed
Aug 6, 2020
| @@ -232,7 +232,7 @@ protected override void OnModelCreating(ModelBuilder modelBuilder, DbContext con | |||
| .UsingEntity<Dictionary<string, object>>( | |||
There was a problem hiding this comment.
Can this pair be configured by convention? (I can update that as it can cause SQL assertion updates)
There was a problem hiding this comment.
Yes, I changed the convention for the FK properties and added TODOs here so you can remove the usings.
smitpatel
approved these changes
Aug 6, 2020
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make join entity type name deterministic
Use skip navigation name for the implicit FK name
Fixes #21858
Fixes #21870
Fixes #21915