Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameterless constructors to value converters #25415

Closed
ajcvickers opened this issue Aug 4, 2021 · 0 comments · Fixed by #25454
Closed

Add parameterless constructors to value converters #25415

ajcvickers opened this issue Aug 4, 2021 · 0 comments · Fixed by #25454
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Milestone
6.0.0

Comments

@ajcvickers
Copy link
Member

We now dynamically create instances of value converter classes that have default constructors, but many of our built-in converters have an optional parameter. For example:

public EnumToStringConverter(ConverterMappingHints? mappingHints = null)
@ajcvickers ajcvickers self-assigned this Aug 6, 2021
@ajcvickers ajcvickers added this to the 6.0.0 milestone Aug 6, 2021
ajcvickers added a commit that referenced this issue Aug 8, 2021
@ajcvickers
Add parameterless constructors to value converters
1e6d0c6 
Fixes #25415
@ajcvickers ajcvickers mentioned this issue Aug 8, 2021
Merged
@ajcvickers ajcvickers added the closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. label Aug 8, 2021
ajcvickers added a commit that referenced this issue Aug 9, 2021
@ajcvickers
Add parameterless constructors to value converters (#25454)
eb44e96 
Fixes #25415
@ajcvickers ajcvickers modified the milestones: 6.0.0, 6.0.0-rc1 Aug 12, 2021
@ajcvickers ajcvickers modified the milestones: 6.0.0-rc1, 6.0.0 Nov 8, 2021
@ajcvickers ajcvickers removed their assignment Sep 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area-change-tracking closed-fixed The issue has been fixed and is/will be included in the release indicated by the issue milestone. type-enhancement
Projects
None yet
Milestone
6.0.0
Development

Successfully merging a pull request may close this issue.

Add parameterless constructors to value converters dotnet/efcore
1 participant
@ajcvickers