Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add parameterless constructors to value converters #25454

Merged
merged 1 commit into from
Aug 9, 2021
Merged

Add parameterless constructors to value converters #25454

merged 1 commit into from
Aug 9, 2021

Conversation

ajcvickers
Copy link
Member

Fixes #25415

@ajcvickers ajcvickers requested a review from a team August 8, 2021 17:00
roji
roji approved these changes Aug 8, 2021
View reviewed changes
Copy link
Member

@roji roji left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could also have an API consistency test to ensure that type converters have a default constructor.

@ajcvickers
Copy link
Member Author

Except not all value converters should have default constructors. Plenty in our code do not.

@ajcvickers ajcvickers merged commit eb44e96 into main Aug 9, 2021
@ajcvickers ajcvickers deleted the ParameterlessMeansParameterless0808 branch August 9, 2021 12:12
@ajcvickers ajcvickers mentioned this pull request Aug 12, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@roji roji roji approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add parameterless constructors to value converters
2 participants
@ajcvickers @roji