Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Preview6] Add an ability to do split query for collection include #21219

Merged
merged 6 commits into from
Jun 12, 2020
Merged

[Preview6] Add an ability to do split query for collection include #21219

merged 6 commits into from
Jun 12, 2020

Conversation

smitpatel
Copy link
Member

Resolves #20892

@smitpatel
Query: Introduce FromSqlQueryingEnumerable for non composed FromSql (#…
bf0eed4 
…21180)

- Move ReaderColumns to RelationalCommandCache
@smitpatel
Query: Refactor shaper processing for relational (#21181)
4f2c7ce 
- This makes is single pass, end to end processing.
- This is required since split queries need to integrate a processed shaper inside a client method while working on outer shaper.
@smitpatel
Query: Perform join operations when one of the source has client eval (…
c5ca9ff 
…#21201)

Resolves #19247
Resolves #17763
Lays ground work for #20291
Required for #20892
@smitpatel
Query: Introduce AsSplitQuery operator to run collection projection i…
71b78cc 
…n separate command for relational (#21189)

part of  #20892
@smitpatel
Add tests for split include and no tracking (#21218)
fc33923 
Part of #20892
@smitpatel
Add support for split query for non-composed collections (#21224)
936d483 
- Added tests for filtered include but only Where filter works for now.
- Copy over tags to inner SelectExpression

Part of #20892
@smitpatel smitpatel marked this pull request as ready for review June 12, 2020 07:02
ajcvickers
ajcvickers approved these changes Jun 12, 2020
View reviewed changes
Copy link
Member

@ajcvickers ajcvickers left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But wait for Steve to approve...

@ajcvickers
Copy link
Member

@smitpatel Approved; you may merge.

@smitpatel smitpatel merged commit 936d483 into release/5.0-preview6 Jun 12, 2020
@smitpatel smitpatel deleted the feature/splitInclude branch June 12, 2020 18:25
@ajcvickers ajcvickers mentioned this pull request Jun 18, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ajcvickers ajcvickers ajcvickers approved these changes

@maumar maumar Awaiting requested review from maumar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@smitpatel @ajcvickers