Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move some provider-facing tests to specifications #22574

Merged
1 commit merged into from
Sep 17, 2020
Merged

Move some provider-facing tests to specifications #22574

1 commit merged into from
Sep 17, 2020

Conversation

roji
Copy link
Member

@roji roji commented Sep 17, 2020

  • Moved to specifications: ApiConsistency, MigrationsSqlGenerator, UpdateSqlGeneratorTestBase, ModelValidatorTestBase (and Relational)
  • Rearranged migrations tests under Migrations folder
  • Reorganized SqlGenerationHelperTest split to simple, separate RelationalSqlGenerationHelperTest and SqlServerSqlGenerationHelperTest
  • Suppress warning for underscores in test names

Closes #11500

@roji roji requested a review from a team September 17, 2020 08:35
@ErikEJ
Copy link
Contributor

ErikEJ commented Sep 17, 2020

Finally!

* Moved to specifications: ApiConsistency, MigrationsSqlGenerator,
  UpdateSqlGeneratorTestBase, ModelValidatorTestBase (and Relational)
* Rearranged migrations tests under Migrations folder
* Reorganized SqlGenerationHelperTest split to simple, separate
  RelationalSqlGenerationHelperTest and
  SqlServerSqlGenerationHelperTest
* Suppress warning for underscores in test names

Closes #11500
@ghost
Copy link

ghost commented Sep 17, 2020

Hello @roji!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3974d3f into main Sep 17, 2020
@ghost ghost deleted the TestCleanup branch September 17, 2020 17:51
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move some provider-facing tests to specifications
3 participants