-
Notifications
You must be signed in to change notification settings - Fork 3.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rewrite the funcletizer to support precompiled queries #33106
Conversation
FYI I'm happy to go over the code with whoever wants to review, or possibly to do a brown bag if people are interested. |
Note: the new mode (path calculation for precompiled queries) is obviously not well-tested; I will very likely be revisiting the funceltizer as part of later NativeAOT work. So there are likely some bugs in those specific bugs of the code - that's expected. |
Closes dotnet#32999 Closes dotnet#32698 Closes dotnet#33012
awesome stuff! |
Thanks for the reviewing and the suggestions @maumar! |
private bool _calculatingPath; | ||
|
||
/// <summary> | ||
/// Indicates whether we should parameterize. Is false in in compiled query mode, as well as when we're handling query filters |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Extra 'in'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Will do in next commit
Here's the rewrite of ParameterExtractingExpressionVisitor, to support precompiled queries.
Closes #32999
Closes #32698
Closes #33012