Fix MemberExpression funcletization #33241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug in the new funcletizer (#33106), found while syncing EFCore.PG to preview.2.
When a MemberExpression is evaluatable, we need to treat it as containing a captured variable, so that it gets parameterized - because evaluating the member again may yield a different answer (the exception is a static readonly member, which can be constantized). We were doing that, but only when the MemberExpression is the root of the evaluatable fragment; when it was embedded inside a larger evaluatable, we incorrectly constantized instead.
Continues #33106