Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Pass sequence annotations (#33780) #33781

Closed
wants to merge 1 commit into from

Conversation

Sielnix
Copy link
Contributor

@Sielnix Sielnix commented May 22, 2024

Fixes #33780

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@AndriySvyryd AndriySvyryd changed the title Pass sequence annotations (#33780) [release/8.0] Pass sequence annotations (#33780) May 23, 2024
@Sielnix
Copy link
Contributor Author

Sielnix commented May 24, 2024 via email

@cincuranet
Copy link
Contributor

@Sielnix can you please create the PR for main branch and we will backport to 8, if it passes the bar. Thanks.

@Sielnix
Copy link
Contributor Author

Sielnix commented May 24, 2024

Thank you @cincuranet , created new PR 33804, this one can be closed.

@cincuranet
Copy link
Contributor

Thanks.

@cincuranet cincuranet closed this May 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants