Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Pass sequence annotations (#33780) #33804

Merged
merged 1 commit into from
May 30, 2024

Conversation

Sielnix
Copy link
Contributor

@Sielnix Sielnix commented May 24, 2024

Fixes #33780

  • I've read the guidelines for contributing and seen the walkthrough
  • I've posted a comment on an issue with a detailed description of how I am planning to contribute
  • The code builds and tests pass locally (also verified by our automated build checks)
  • Commit messages follow this format:
        Summary of the changes
        - Detail 1
        - Detail 2

        Fixes #bugnumber
  • Tests for the changes have been added (for bug fixes / features)
  • Code follows the same patterns and style as existing code in this repo

@cincuranet
Copy link
Contributor

@roji I think you're my backup on scaffolding, can you give me 2nd set of eyes here?

@cincuranet cincuranet requested a review from roji May 24, 2024 15:36
@ajcvickers
Copy link
Contributor

@cincuranet Looks good to me.

@cincuranet cincuranet merged commit 3fa01db into dotnet:main May 30, 2024
7 checks passed
@cincuranet
Copy link
Contributor

@Sielnix thanks for the contribution.

@Sielnix Sielnix deleted the fix_main_sequence_annotations branch June 6, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Sequence annotations are not passed to code generation
3 participants