Use TokenCredential for Cosmos tests #33956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
roji
approved these changes
Jun 11, 2024
test/EFCore.Cosmos.FunctionalTests/TestUtilities/CosmosTestStore.cs
Outdated
Show resolved
Hide resolved
ajcvickers
reviewed
Jun 11, 2024
| @@ -223,10 +226,50 @@ private async Task CreateFromFile(DbContext context) | |||
| } | |||
| } | |||
|
|
|||
| private static readonly ArmClient _armClient = new(TestEnvironment.TokenCredential); | |||
|
|
|||
| public async Task<bool> EnsureCreatedAsync(DbContext context, CancellationToken cancellationToken = default) | |||
There was a problem hiding this comment.
Why do we have to fall out of EF code completely here. Is there not a way to use CreateDatabaseIfNotExistsAsync or fix it so it can be used?
There was a problem hiding this comment.
To do that we'd need to take a dependency on Azure.ResourceManager.CosmosDB and take resource group, subscription id, account name and AzureLocation as additional options.
There was a problem hiding this comment.
@AndriySvyryd Do we have an issue for that?
|
@dotnet-policy-service rerun |
AndriySvyryd
force-pushed
the
SecureCosmos
branch
from
74fe0e4 to
2e8e1d7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We need to use
Azure.ResourceManager.CosmosDBto create and delete databases because these operations aren't supported by the data-plane Cosmos SDK with Managed Identities