Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[release/8.0] Use TokenCredential for Cosmos tests #33966

Merged
merged 1 commit into from
Jun 12, 2024

Conversation

AndriySvyryd
Copy link
Member

@AndriySvyryd AndriySvyryd commented Jun 11, 2024

Port of #33956
Required for https://devdiv.visualstudio.com/DevDiv/_workitems/edit/2054020

Description

We test the EF Cosmos DB provider against an Azure Cosmos DB account. A new requirement for these non-production accounts is to use managed identity authentication.
This PR contains the changes needed to prevent build failures once local auth is disabled for these accounts. It was erroneously merged after code complete without explicit approval.

Customer impact

N/A

How found

S360

Regression

N/A

Testing

Tested using a manual pipeline run

Risk

Low, test-only change

@AndriySvyryd AndriySvyryd requested a review from a team June 11, 2024 23:08
@AndriySvyryd AndriySvyryd requested a review from maumar as a code owner June 11, 2024 23:08
@AndriySvyryd AndriySvyryd force-pushed the SecureCosmos_8.0 branch 3 times, most recently from 052919f to 206b928 Compare June 12, 2024 03:40
@AndriySvyryd AndriySvyryd enabled auto-merge (squash) June 12, 2024 17:32
@AndriySvyryd AndriySvyryd merged commit 15d21bf into release/8.0 Jun 12, 2024
7 checks passed
@AndriySvyryd AndriySvyryd deleted the SecureCosmos_8.0 branch June 12, 2024 18:18
@AndriySvyryd AndriySvyryd added this to the 8.0.7 milestone Jun 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants