Update the SDK #1431

davidfowl · 2019-04-16T02:05:24Z

I'd like to try out netstandard2.1 in various extensions projects

Tratcher · 2019-04-16T05:20:23Z

src/Hosting/samples/GenericHostSample/GenericHostSample.csproj

@@ -2,7 +2,6 @@

  <PropertyGroup>
    <TargetFrameworks>netcoreapp3.0;net461</TargetFrameworks>
-    <RuntimeIdentifiers>win7-x64;linux-x64;osx-x64</RuntimeIdentifiers>


Why? These were useful for testing the windows service.

Maybe, they're useful for net461 maybe but we now make native exes by default. I was also just trying to see if this would fix the issue I was running into but it didn't.

I was using them for standalone publish.

Why? You had to do that in the past to get an exe, not you don't. What other reason did you have to self contain deploying this app?

Services run as different users without access to the repo local runtime. It's easier to deploy the runtime with the service than to tell the service how to find it.

You can publish self contained without putting RIDS in the prodject file and doing a RID restore. That's been the case since 2.x.

davidfowl · 2019-04-16T17:51:08Z

dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
.dotnet\sdk\3.0.100-preview4-011136\Sdks\Microsoft.NET.Sdk\targets\Microsoft.NET.Sdk.targets(115,5): Error NETSDK1085: The 'NoBuild' property was set to true but the 'Build' target was invoked.
PowerShell exited with code '1'.

Anybody know wtf this is https://github.com/aspnet/Extensions/blob/92acd8b95901f1e8f47d3d128cb5f7c38b684644/src/Shared/src/Directory.Build.props#L9

natemcmaster · 2019-04-16T17:52:42Z

This is how we hacked the SDK into producing '.Sources' packages.

davidfowl · 2019-04-17T07:01:30Z

I see this was added:

https://github.com/dotnet/sdk/blob/8cb31b0fd0bb5d36b9781442865f2e26cf6fbedc/src/Tasks/Microsoft.NET.Build.Tasks/targets/Microsoft.NET.Sdk.targets#L113-L116

@dsplaisted How do we build a package source only package? Is there anyway to disable this?

dsplaisted · 2019-04-17T16:46:20Z

What is a package source only package?

The check was added to make sure that when you specify "no build", it doesn't actually run the Build target. I'm not sure there's a point in disabling the check, if you are getting the error and want to disable the check, I think you'd get the same result by no longer specifying NoBuild. However, I don't know anything about the hack Nate refers to to produce source packages, so that could be an exception.

natemcmaster · 2019-04-17T17:55:22Z

A source package is a .nupkg which only contains *.cs content files, no .dll. I think <NoBuild> was set to suppress the C# compiler from ever running. These projects are using a .csproj as a hack to produce a .nupkg since we don’t have the ability to pack a nuspec directly.

dsplaisted · 2019-04-17T18:02:15Z

I believe it is possible by now to use the Pack target to create a .nupkg from a .nuspec.

I think if you're getting the NoBuildRequested error, it means that some target that was running had a dependency on the Build target, so essentially you would be compiling the code anyway if the error wasn't there.

natemcmaster · 2019-04-17T20:12:21Z

I’m not aware of any changes to nuget and packing. Sure, you can call the pack target and provide a nuspec….but you still need a .csproj file in order to invoke the Pack target, right? That’s what these dummy .csproj files are for.

dsplaisted · 2019-04-17T20:21:41Z

Yes, you still need a dummy .csproj.

natemcmaster

Further investigation into the CodeCheck.ps1 failures on ref assemblies has turned up a combination of problems:

The GenAPI tool doesn't consider LangVersion when generating source GenAPI generates invalid C# arcade#2555
New versions of Roslyn are emitting IsReadOnlyAttribute for auto-properties Compiler is emitting IsReadOnlyAttribute for getter only auto properties when not targeting 8.0 roslyn#35113

@davidfowl we could try updating LangVersion to target 8.0. If that doesn't work, we'll need to hold off on this change until we find a workaround or fix.

natemcmaster · 2019-04-22T23:38:26Z

/azp run

azure-pipelines · 2019-04-22T23:38:39Z

Azure Pipelines successfully started running 1 pipeline(s), but failed to run 1 pipeline(s).

natemcmaster · 2019-04-23T04:29:04Z

PR checks are passing now

davidfowl · 2019-04-23T04:29:28Z

FINALLY! 😄

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true \n\nCommit migrated from dotnet/extensions@b473a78

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true Commit migrated from dotnet/extensions@b473a78

davidfowl requested a review from natemcmaster April 16, 2019 02:05

davidfowl requested review from analogrelay and Tratcher as code owners April 16, 2019 05:06

Tratcher reviewed Apr 16, 2019

View reviewed changes

davidfowl added 3 commits April 17, 2019 09:50

Update the SDK

0cd3713

Remove rids

7cfd04c

set GeneratePackgeOnBuild to true

c00275a

davidfowl force-pushed the davidfowl/update-sdk branch from 6e350c1 to c00275a Compare April 17, 2019 16:51

Eilon added the area-infrastructure label Apr 18, 2019

natemcmaster reviewed Apr 18, 2019

View reviewed changes

davidfowl mentioned this pull request Apr 21, 2019

Add IAsyncDisposable support in netstandard2.1 #1467

Closed

natemcmaster pushed a commit to dotnet-maestro-bot/Common that referenced this pull request Apr 22, 2019

Allow running some IIS Express variants without publishing dotnet#1431

8d55a44

natemcmaster approved these changes Apr 23, 2019

View reviewed changes

davidfowl merged commit b473a78 into master Apr 23, 2019

natemcmaster deleted the davidfowl/update-sdk branch April 23, 2019 04:30

JunTaoLuo pushed a commit to dotnet/aspnetcore that referenced this pull request Feb 12, 2020

Update the SDK (dotnet/extensions#1431)

0d2b266

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true \n\nCommit migrated from dotnet/extensions@b473a78

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Feb 28, 2020

Update the SDK (dotnet/extensions#1431)

757c1fb

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true Commit migrated from dotnet/extensions@b473a78

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 2, 2020

Update the SDK (dotnet/extensions#1431)

f20b201

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true Commit migrated from dotnet/extensions@b473a78

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 11, 2020

Update the SDK (dotnet/extensions#1431)

0d5477d

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true Commit migrated from dotnet/extensions@b473a78

maryamariyan pushed a commit to maryamariyan/runtime that referenced this pull request Mar 27, 2020

Update the SDK (dotnet/extensions#1431)

2e47987

* Update the SDK * Remove rids * set GeneratePackgeOnBuild to true Commit migrated from dotnet/extensions@b473a78

ghost locked as resolved and limited conversation to collaborators May 28, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Update the SDK #1431

Update the SDK #1431

davidfowl commented Apr 16, 2019 •

edited

Loading

Tratcher Apr 16, 2019

davidfowl Apr 16, 2019

Tratcher Apr 16, 2019

davidfowl Apr 16, 2019

Tratcher Apr 16, 2019

davidfowl Apr 16, 2019

davidfowl commented Apr 16, 2019 •

edited

Loading

natemcmaster commented Apr 16, 2019

davidfowl commented Apr 17, 2019

dsplaisted commented Apr 17, 2019

natemcmaster commented Apr 17, 2019 via email

dsplaisted commented Apr 17, 2019

natemcmaster commented Apr 17, 2019 via email

dsplaisted commented Apr 17, 2019

natemcmaster left a comment

natemcmaster commented Apr 22, 2019

azure-pipelines bot commented Apr 22, 2019

natemcmaster commented Apr 23, 2019

davidfowl commented Apr 23, 2019

Update the SDK #1431

Update the SDK #1431

Conversation

davidfowl commented Apr 16, 2019 • edited Loading

Tratcher Apr 16, 2019

Choose a reason for hiding this comment

davidfowl Apr 16, 2019

Choose a reason for hiding this comment

Tratcher Apr 16, 2019

Choose a reason for hiding this comment

davidfowl Apr 16, 2019

Choose a reason for hiding this comment

Tratcher Apr 16, 2019

Choose a reason for hiding this comment

davidfowl Apr 16, 2019

Choose a reason for hiding this comment

davidfowl commented Apr 16, 2019 • edited Loading

natemcmaster commented Apr 16, 2019

davidfowl commented Apr 17, 2019

dsplaisted commented Apr 17, 2019

natemcmaster commented Apr 17, 2019 via email

dsplaisted commented Apr 17, 2019

natemcmaster commented Apr 17, 2019 via email

dsplaisted commented Apr 17, 2019

natemcmaster left a comment

Choose a reason for hiding this comment

natemcmaster commented Apr 22, 2019

azure-pipelines bot commented Apr 22, 2019

natemcmaster commented Apr 23, 2019

davidfowl commented Apr 23, 2019

davidfowl commented Apr 16, 2019 •

edited

Loading

davidfowl commented Apr 16, 2019 •

edited

Loading