Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the SDK #1431

Merged
merged 3 commits into from
Apr 23, 2019
Merged

Update the SDK #1431

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
0cd3713
Update the SDK
davidfowl Apr 16, 2019
7cfd04c
Remove rids
davidfowl Apr 16, 2019
c00275a
set GeneratePackgeOnBuild to true
davidfowl Apr 17, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions global.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
{
"sdk": {
"version": "3.0.100-preview3-010280"
"version": "3.0.100-preview4-011136"
},
"tools": {
"dotnet": "3.0.100-preview3-010280"
"dotnet": "3.0.100-preview4-011136"
},
"msbuild-sdks": {
"Microsoft.DotNet.Arcade.Sdk": "1.0.0-beta.19217.1",
Expand Down
1 change: 0 additions & 1 deletion src/Hosting/samples/GenericHostSample/GenericHostSample.csproj
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

<PropertyGroup>
<TargetFrameworks>netcoreapp3.0;net461</TargetFrameworks>
<RuntimeIdentifiers>win7-x64;linux-x64;osx-x64</RuntimeIdentifiers>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? These were useful for testing the windows service.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, they're useful for net461 maybe but we now make native exes by default. I was also just trying to see if this would fix the issue I was running into but it didn't.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I was using them for standalone publish.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why? You had to do that in the past to get an exe, not you don't. What other reason did you have to self contain deploying this app?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Services run as different users without access to the repo local runtime. It's easier to deploy the runtime with the service than to tell the service how to find it.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can publish self contained without putting RIDS in the prodject file and doing a RID restore. That's been the case since 2.x.

<StartupObject>GenericHostSample.WindowsServiceControlled</StartupObject>
<OutputType>Exe</OutputType>
<LangVersion>latest</LangVersion>
Expand Down
1 change: 1 addition & 0 deletions src/Shared/src/Directory.Build.props
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
<IsPackable>true</IsPackable>
<IsShipping>false</IsShipping>
<NoBuild>true</NoBuild>
<GeneratePackageOnBuild>true</GeneratePackageOnBuild>
<GenerateAssemblyInfo>false</GenerateAssemblyInfo>
<EnableDefaultItems>false</EnableDefaultItems>
<IncludeBuildOutput>false</IncludeBuildOutput>
Expand Down