-
Notifications
You must be signed in to change notification settings - Fork 761
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
AsyncState can be used across different service providers #4966
AsyncState can be used across different service providers #4966
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Few more issues to tackle
test/Libraries/Microsoft.Extensions.AsyncState.Tests/AsyncStateTests.cs
Outdated
Show resolved
Hide resolved
…est. Added comment to warning disable. Added header to AssemblyInfo.cs
The counter is always increasing and declared as |
@sebastienros Yes, the int is increasing but only when we create a new instance of AsyncContext<>. But we register these types as singletons (
|
Current implementation of AsyncState has problems.
This PR fixes #4959 by making the field _contextCount static.
Microsoft Reviewers: Open in CodeFlow